Use PrecompileTools for artifact resolution#508
Open
langestefan wants to merge 3 commits intoJuliaTime:masterfrom
Open
Use PrecompileTools for artifact resolution#508langestefan wants to merge 3 commits intoJuliaTime:masterfrom
langestefan wants to merge 3 commits intoJuliaTime:masterfrom
Conversation
…on data from skipping runtime _build()
giordano
reviewed
Feb 27, 2026
|
|
||
| @static if VERSION >= v"1.9" | ||
| # Also sets _COMPILED_DIR so the TimeZone("UTC") call below can load tzdata. | ||
| _COMPILED_DIR[] = _resolve_tzjdata_dir() |
Contributor
There was a problem hiding this comment.
I'm not familiar with the internals of the package, but in general backing at precompile time constants which are supposed to be evaluated at runtime is a bad idea. Or that's changed again at runtime?
Author
There was a problem hiding this comment.
yes this is changed at runtime, in __init__ at https://github.com/langestefan/TimeZones.jl/blob/50d3fad5757df6725dfb073de7204c6fcd0f7ee8/src/TimeZones.jl#L59
Author
|
@omus could you take a look at this if you have a minute? thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507
Created with help of Claude (hence the verbose comments, can be removed ofcourse)