Skip to content

Fix support for version JULIA_TZ_VERSION=latest#365

Merged
omus merged 1 commit into
masterfrom
cv/tzdata-latest-fix
Oct 18, 2021
Merged

Fix support for version JULIA_TZ_VERSION=latest#365
omus merged 1 commit into
masterfrom
cv/tzdata-latest-fix

Conversation

@omus
Copy link
Copy Markdown
Member

@omus omus commented Oct 15, 2021

Mistake introduced in #363 and results in:

ERROR: LoadError: UndefVarError: latest_version not defined
Stacktrace:
 [1] build(version::String, regions::Vector{String}, tz_source_dir::String, compiled_dir::String; verbose::Bool)
   @ TimeZones.TZData ~/.julia/dev/TimeZones/src/tzdata/build.jl:33
 [2] build(version::String)
   @ TimeZones.TZData ~/.julia/dev/TimeZones/src/tzdata/build.jl:68
 [3] build(version::String; force::Bool)
   @ TimeZones ~/.julia/dev/TimeZones/src/build.jl:11
 [4] build (repeats 2 times)
   @ ~/.julia/dev/TimeZones/src/build.jl:11 [inlined]
 [5] top-level scope
   @ ~/.julia/dev/TimeZones/deps/build.jl:3
 [6] include(fname::String)
   @ Base.MainInclude ./client.jl:444
 [7] top-level scope
   @ none:5
in expression starting at /Users/omus/.julia/dev/TimeZones/deps/build.jl:3

If the user has the env variable JULIA_TZ_VERSION=latest set. Change will be backported to 1.5

@omus
Copy link
Copy Markdown
Member Author

omus commented Oct 15, 2021

Based upon the tests passing in #363 this code path is untested.

@omus omus self-assigned this Oct 18, 2021
@omus omus merged commit 1921d7d into master Oct 18, 2021
@omus omus deleted the cv/tzdata-latest-fix branch October 18, 2021 19:16
@omus
Copy link
Copy Markdown
Member Author

omus commented Oct 18, 2021

Should be backported to 1.5

Update: Error was not present in 1.5

kpamnany pushed a commit to RelationalAI-oss/TimeZones.jl that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant