Use ShortStrings for names of both Fixed and Variable timezones#330
Open
oxinabox wants to merge 2 commits intoJuliaTime:masterfrom
Open
Use ShortStrings for names of both Fixed and Variable timezones#330oxinabox wants to merge 2 commits intoJuliaTime:masterfrom
oxinabox wants to merge 2 commits intoJuliaTime:masterfrom
Conversation
Tweak comment tweak comment do use split with short strings Julia needs brakets for function application
oxinabox
force-pushed
the
ox/ssnameBoth2
branch
from
7024d91 to
d2fdec9
Compare
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 92.51% 93.60% +1.08%
==========================================
Files 32 32
Lines 1510 1532 +22
==========================================
+ Hits 1397 1434 +37
+ Misses 113 98 -15
Continue to review full report at Codecov.
|
This was referenced Apr 14, 2021
omus
reviewed
Apr 14, 2021
Member
omus
left a comment
omus
left a comment
There was a problem hiding this comment.
So much cleaner! I'm feeling good about this. I'll reach out to Scott about getting 32-bit fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is made on top of #327
it is based on this comment #324 (comment)
contributes towards #271
but doesn't solve it since VariableTimeZones still have Vector fields,
and the ZonedDateTime isnb't parameteric on it's timezone type.