You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fail-fast on GHA doesn't work great.
The benchmark job erroring shouldn't prevent the actual testing jobs from running.
Since the benchmarking job can error if you change how any types are defined #327 (comment)
So the solution to this is to actually set fast-fail: false on just the benchmark job. With this then a failure from the benchmark job will not impact any other running job but jobs with fast-fail: true will cause other jobs to be cancelled. I'll make a PR for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail-fast on GHA doesn't work great.
The benchmark job erroring shouldn't prevent the actual testing jobs from running.
Since the benchmarking job can error if you change how any types are defined #327 (comment)