WIP: Compile time zone information during package initialization#295
Open
WIP: Compile time zone information during package initialization#295
Conversation
Contributor
|
Another possibility is to serialize it out to files stored in scratch spaces, keyed by the Julia version. e.g. using Scratch
tz_path = joinpath(@get_scratch!("tz-data-$(VERSION.major).$(VERSION.minor)"), ...) |
Member
Author
Great idea. I'll definitely try that out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288. Originally TimeZones.jl serialized the compiled time zone information to reduce the time it took to load the package. Julia has had many improvements since then and now it seems feasible to compile the time zone information during package initialization.
Some benchmarking on Julia 1.5.2:
Current master (42bc067)
Current PR:
There is definitely a performance penalty for doing this but it does make the package state more immutable which is something Julia packages in general are moving towards. There are some easy performance gains to be made yet including: