Skip to content

[SLATE] New builder#4093

Merged
giordano merged 16 commits into
JuliaPackaging:masterfrom
rayegun:SLATE_build
Jun 7, 2022
Merged

[SLATE] New builder#4093
giordano merged 16 commits into
JuliaPackaging:masterfrom
rayegun:SLATE_build

Conversation

@rayegun

@rayegun rayegun commented Dec 19, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@rayegun

rayegun commented Dec 19, 2021

Copy link
Copy Markdown
Contributor Author

resolves #3941

@rayegun rayegun marked this pull request as ready for review December 19, 2021 01:01
@rayegun

rayegun commented Dec 19, 2021

Copy link
Copy Markdown
Contributor Author

Only thing I'm not particularly sure about is using MPITrampoline here. I did it because I figured we're moving in the direction of trampolines, but I'm not sure what the full story is currently.

@giordano

Copy link
Copy Markdown
Member

but I'm not sure what the full story is currently.

Valentin is experimenting right now (see #4073), I don't think anyone has a clear picture at the moment

@rayegun

rayegun commented Dec 22, 2021

Copy link
Copy Markdown
Contributor Author

Let me block this while I investigate MPI_trampoline and the best current way to call the C++ api (can't do C API with cmake :().

@rayegun rayegun marked this pull request as draft December 22, 2021 23:51
@rayegun

rayegun commented Jun 6, 2022

Copy link
Copy Markdown
Contributor Author

Why would these implicit conversions be errors on macOS and BSD but not Linux?

@giordano

giordano commented Jun 6, 2022

Copy link
Copy Markdown
Member

Because BSD systems use Clang, Linux uses GCC. Different compilers have different opinions.

@rayegun

rayegun commented Jun 6, 2022

Copy link
Copy Markdown
Contributor Author

Oh I wasn't aware Clang was used on BSD. I'll disable them and file upstream then I guess? I need to add back fortran expansion too.

@giordano

giordano commented Jun 6, 2022

Copy link
Copy Markdown
Member

Yeah, it does sound like a bug, it's just that GCC may be more permissive.

Comment thread S/SLATE/build_tarballs.jl
@rayegun rayegun marked this pull request as ready for review June 7, 2022 20:02
@giordano giordano merged commit 14eda3d into JuliaPackaging:master Jun 7, 2022
@jishnub jishnub mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants