Skip to content

MPI: Experimental platform tag #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vchuravy wants to merge 5 commits into from
Closed

MPI: Experimental platform tag #4073

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3104b78
MPI: Experimental platform tag
vchuravy Dec 17, 2021
0946119
fixup BBB
vchuravy Dec 17, 2021
4c5599a
filter OS correctly
vchuravy Dec 17, 2021
12cbca5
use MPIABI
vchuravy Dec 18, 2021
c26ee64
Use branches with fixes
vchuravy Dec 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .ci/Manifest.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 30 additions & 3 deletions L/LAMMPS/build_tarballs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Note that this script can accept some limited command-line arguments, run
# `julia build_tarballs.jl --help` to see a usage message.
using BinaryBuilder, Pkg
using Base.BinaryPlatforms

name = "LAMMPS"
version = v"1.0.1" # Equivalent to 2020-10-29
Expand Down Expand Up @@ -58,12 +59,38 @@ products = [
ExecutableProduct("lmp", :lmp),
]

mpi_abis = (
(:mpich, PackageSpec(name="MPICH_jll"), "") ,
(:msmpi, PackageSpec(name="MicrosoftMPI_jll"), ""),
(:mpitrampoline, PackageSpec(name="MPItrampoline_jll"), "2")
)

# Dependencies that must be installed before this package can be built
dependencies = [
Dependency(PackageSpec(name="CompilerSupportLibraries_jll")),
Dependency(PackageSpec(name="MPItrampoline_jll"), compat="2"),
Dependency(PackageSpec(name="MicrosoftMPI_jll"))
# Dependency(PackageSpec(name="MPIPlatformTag")),

@vchuravy vchuravy Dec 17, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@staticfloat @simonbyrne

I am debating if this should be MPI.jl or a tiny single preference package.

]

all_platforms = AbstractPlatform[]
for (abi, pkg, compat) in mpi_abis
pkg_platforms = deepcopy(platforms)
Comment thread
vchuravy marked this conversation as resolved.
Outdated
foreach(pkg_platforms) do p
BinaryPlatforms.add_tag!(p.tags, "mpi", string(abi))
end
append!(all_platforms, pkg_platforms)
push!(dependencies, Dependency(pkg; compat, platforms=pkg_platforms))
end

augmented_platform_block = """
using Base.BinaryPlatforms
# using MPIPlatformTag

function augmented_platform(platform)
Comment thread
vchuravy marked this conversation as resolved.
Outdated
abi = :mpich
# abi = MPIPlatformTag.get_abi()
BinaryPlatforms.add_tag!(platform.tags, "mpi", string(abi))
return platform
end
"""
# Build the tarballs, and possibly a `build.jl` as well.
build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat="1.6", preferred_gcc_version=v"8")
build_tarballs(ARGS, name, version, sources, script, all_platforms, products, dependencies; julia_compat="1.6", preferred_gcc_version=v"8")