All infrastructure to allow Pkg to download all Artifacts#43484
Closed
vchuravy wants to merge 1 commit into
Closed
All infrastructure to allow Pkg to download all Artifacts#43484vchuravy wants to merge 1 commit into
vchuravy wants to merge 1 commit into
Conversation
vchuravy
added
backport 1.6
Member
Author
|
@staticfloat told me that I am barking up the wrong tree. |
KristofferC
removed
backport 1.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In working on custom platform tags in BinaryBuilder and JLLWrappers I run into the following show-stopper.
Currently Pkg uses
artifact_metato find the one artifact it is supposed to be downloading for this platform.Since Pkg does not know anything about the augmented platform it picks one of them (effictivly at random).
See JuliaPackaging/JLLWrappers.jl#35 (comment) and the failing CI there for an example.
The artifacts for
LAMMPS_jllhave a custom tag, describing the MPI abi and uses theaugment_platform!to choose which of thewrapper to target.
I think we have to be conservative and actually download all of them.