Skip to content

add JSONText methods for Symbol and JSONText #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hhaensel wants to merge 4 commits into
base: master
Choose a base branch
from
+31 −1
Open

add JSONText methods for Symbol and JSONText #427

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbdc049
add JSONText methods for Symbol and JSONText
Jan 22, 2026
a6250a9
remove JSONText for Symbols
Feb 12, 2026
c770cc5
add and publicize `@js_str` macro
Feb 12, 2026
c39cb68
remove JSONText(Symbol(...)) from tests
Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/JSON.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ x = JSON.parse("[1,2,3]", JSONText)
struct JSONText
value::String
end
JSON.JSONText(js::Symbol) = JSONText(String(js))
Copy link
Copy Markdown
Member

@quinnj quinnj Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definition feels really weird/unnecessary to me (who has valid json as a symbol?). I think I'd prefer to not support for now. I think the other definition is fine.

Copy link
Copy Markdown
Contributor Author

@hhaensel hhaensel Jan 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've written a Julia to JS expression conversion where I use Symbols to mean js variables, e.g.

julia> @jsexpr(:x^2 + :b * :y + 2)
JSExpr("(((x ** 2) + (b * y)) + 2)")

In this context it comes in very handy to automatically convert Symbols to JSONText.

Copy link
Copy Markdown
Contributor Author

@hhaensel hhaensel Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the definition for Symbol

JSON.JSONText(js::JSONText) = js

include("lazy.jl")
include("parse.jl")
Expand Down
4 changes: 3 additions & 1 deletion test/json.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ end
arr[3] = "b"
@test JSON.json(arr) == "[\"a\",null,\"b\"]"
# test custom struct writing
# defined in the test/struct.jl file
# defined in the test/parse.jl file
a = A(1, 2, 3, 4)
@test JSON.json(a) == "{\"a\":1,\"b\":2,\"c\":3,\"d\":4}"
x = LotsOfFields("1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16", "17", "18", "19", "20", "21", "22", "23", "24", "25", "26", "27", "28", "29", "30", "31", "32", "33", "34", "35")
Expand Down Expand Up @@ -256,6 +256,8 @@ end
@test JSON.json(Dict(Point(1, 2) => "hi")) == "{\"1_2\":\"hi\"}"
x = JSONText("[1,2,3]")
@test JSON.json(x) == "[1,2,3]"
@test JSONText(x) == x
@test x == JSONText(Symbol("[1,2,3]"))
@test JSON.json((a=1, b=nothing)) == "{\"a\":1,\"b\":null}"
@test JSON.json((a=1, b=nothing); omit_null=true) == "{\"a\":1}"
@test JSON.json((a=1, b=nothing); omit_null=false) == "{\"a\":1,\"b\":null}"
Expand Down
Loading