Run examples in isolated test processes#771
Open
AshtonSBradley wants to merge 1 commit intoJuliaGPU:mainfrom
Open
Run examples in isolated test processes#771AshtonSBradley wants to merge 1 commit intoJuliaGPU:mainfrom
AshtonSBradley wants to merge 1 commit intoJuliaGPU:mainfrom
Conversation
fdc578e to
8604073
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples may load packages that mutate global numerical-library state, such as AppleAccelerate. When examples are included directly in the package test runner, that state can leak into unrelated tests scheduled later on the same worker.
This keeps example coverage, but runs each example in a fresh Julia process with the example project active and TESTING=true. That makes the test suite independent of example load order and avoids example-only dependencies contaminating later package tests.
One example where this matters is #713, which adds FFT tests that should not depend on whether the flops comparison example loaded AppleAccelerate earlier on the same worker. The same isolation should help any future example that pulls in process-global state.
Type stability / allocation impact: this changes only how examples are run during tests. There is no public API or package runtime impact. Example tests now pay one Julia process startup per example in exchange for hermetic test state.