Skip to content

unordered hash for OrderedSet #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willow-ahrens wants to merge 2 commits into
base: master
Choose a base branch
from
Open

unordered hash for OrderedSet #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cf7467
unordered
willow-ahrens Apr 18, 2025
83a1117
I didn't realize this was tested behavior
willow-ahrens Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ordered_set.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ end
function hash(s::OrderedSet, h::UInt)
h = hash(orderedset_seed, h)
s.dict.ndel > 0 && rehash!(s.dict)
hash(s.dict.keys, h)
h_2 = UInt(0)
for k in s.dict.keys
h_2 ⊻= hash(k, h)
end
h_2
end

# Deprecated functionality, see
Expand Down
2 changes: 1 addition & 1 deletion test/test_ordered_set.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ using OrderedCollections, Test
s1 = OrderedSet{String}(["bar", "foo"])
s2 = OrderedSet{String}(["foo", "bar"])
s3 = OrderedSet{String}(["baz"])
@test hash(s1) != hash(s2)
@test hash(s1) == hash(s2)
@test hash(s1) != hash(s3)
end

Expand Down
Loading