Conversation
- now there is a 'default' argument just like for Dict - if no default is provided and the key is not found it now throws an error as specified in the pop! docstring and also as Dict and OrderedDict do
fingolfin
added
the
breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pop!docstring and also matching whatDictandOrderedDictdo. If anyone needs to adjust existing code that relies onpop!not throwing, they can either provide adefaultvalue, or usedelete!(which returns the dictionary and does not throw if the key is not present).Closely based on PR #59 with a few minor tweaks.
Resolves #61
But beware, this may break some existing code, so I am marking it as "breaking" and putting it onto the 2.0.0 milestone.