Chore/revisit issue 81 - #84
Open
jonasbadstuebner wants to merge 2 commits into
Open
Conversation
Revisits the fix for JonasWanke#81 This implementation uses currentStart to calculate the first timeSet, fixing the error described in JonasWanke#81 whilst still using the shortcut route for frequencies > daily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #81
This PR revisits the fix for #81.
This implementation uses currentStart to calculate the first timeSet, fixing the error described in #81 whilst still using the shortcut route for frequencies > daily.
Because I needed the fix from #82 for the
SECONDLYtest to work, I recommend merging that one first. Then I can rebase and we are good to get this one through.All tests are passing, if you see any other edge case currently not covered by tests, please let me know and I'm happy to look into it.