Revert "Improve Reflection API type hinting (#1810)" - #1897
Merged
Ivan Fedorov (isfedorov) merged 1 commit intoJun 8, 2026
Merged
Conversation
This reverts commit c96a600.
Christian Sciberras (uuf6429)
deleted the
revert-reflection-api-improvements
branch
June 8, 2026 18:11
Contributor
Author
|
Thanks Ivan Fedorov (@isfedorov) and apologies for the extra work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c96a600 due to backward compatibility issues as described here.
Short term: the revert allows phpstan to keep making use of these stubs for the moment.
Long term: I was already going to contribute some further changes with #1896, so instead I'll put the revert changes in there and then we'll see how to have this release without stepping on anyones' feet.