Conversation
handleValueChange is the only place that clears gestureActiveRef.current, and it only runs on a successful gesture completion. If the pan or tap is cancelled — for example when the Native arm of the Race wins, or a parent gesture intercepts — the ref leaks and stays true forever, leaving the consumer stuck in a "seeking" state and freezing any UI driven by it (e.g. progress text, position sync effects). - Pan: switch onEnd to onFinalize and bail with a ref reset on !success. - Tap: reset the ref before the existing !success early return. Behaviour on the success path is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleValueChangeis the only place that resetsgestureActiveRef.currenttofalse, and it only runs after a successful gesture completion. If the pan or tap is cancelled — e.g. when theGesture.Native()arm of theRacewins, or a parent gesture intercepts the touch — the ref leaks and staystrueforever.For consumers that drive UI off
gestureActiveRef, this leaves them stuck in a "seeking" state. In Jellify this surfaces as: the progress bar visually moves on tap, then the timestamp display freezes and stops updating during playback because the consumer's "sync display position to actual playback" effect is gated on!isSeeking.current.It's reproducible reliably on Waydroid (where mouse-derived events lose the
Raceto the Native arm more often than finger taps), and is a latent cause of rare "stuck scrubber" reports on real devices when a parent gesture steals mid-tap.Changes
.onEnd(...)→.onFinalize(...), bail with a ref reset on!success.!successearly return.The success path is byte-identical to before — only the cancel/fail paths now clean up properly.
Test plan