fix: authenticate and resolve selected track before playback - #1390
Open
marcosdefina wants to merge 2 commits into
Open
fix: authenticate and resolve selected track before playback#1390marcosdefina wants to merge 2 commits into
marcosdefina wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
extraPayload.headers, the field Nitro Player 1.5.0 reads on iOS and AndroidMediaBrowserauthorization value instead of a raw tokenTrackPlayer.play()onTracksNeedUpdaterequests complete independently instead of globally aborting the earlier iOS requestWhy
On Jellify 1.2.7 for iOS, selecting a current Jellyfin item can fetch
PlaybackInfosuccessfully but never issue the subsequent/Audio/{id}/streamrequest. The Jellyfin session remains paused at 0 ms. A live reproduction generated repeated PlaybackInfo requests but no audio request.The immediate blocker is that Jellify stores
headersat the top level ofTrackItem, while Nitro Player explicitly readsextraPayload.headers. The native player therefore receives no usable Jellyfin authorization. The selected queue entry also starts withurl: "", and a second lazy-load callback could abort the first selected-track request.This addresses the first-track/paused-at-zero failure mode reported in #1214.
Validation
bunx jest jest/functional/ItemToTrack.test.ts jest/functional/Player/queue.test.ts jest/functional/Player/track-media-info.test.ts --runInBand(42 tests pass)bun run tsc