Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
518 changes: 518 additions & 0 deletions jest/functional/LetterJump.test.ts

Large diffs are not rendered by default.

74 changes: 54 additions & 20 deletions src/api/queries/album/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { InfiniteData, useInfiniteQuery, useQuery } from '@tanstack/react-query'
import { ItemSortBy } from '@jellyfin/sdk/lib/generated-client/models/item-sort-by'
import { SortOrder } from '@jellyfin/sdk/lib/generated-client/models/sort-order'
import { fetchAlbums } from './utils/album'
import { BaseItemDto } from '@jellyfin/sdk/lib/generated-client'
import { BaseItemDto, BaseItemKind, ItemFields } from '@jellyfin/sdk/lib/generated-client'
import flattenInfiniteQueryPages from '../../../utils/query-selectors'
import { ApiLimits, MaxPages } from '../../../configs/query.config'
import { queryClient } from '../../../constants/query-client'
Expand All @@ -14,6 +14,8 @@ import { fetchAlbumDiscs } from '../item'
import { Api } from '@jellyfin/sdk/lib/api'
import { AlbumDiscsQueryKey } from './keys'
import { AlbumQuery, RecentlyAddedQuery } from './queries'
import buildYearsParam from '../../../utils/mapping/build-years-param'
import { createLetterJump } from '../letter-jump'

export const useAlbum = (album: BaseItemDto) => useQuery(AlbumQuery(album))

Expand Down Expand Up @@ -56,28 +58,34 @@ const useAlbums = () => {
return flattenInfiniteQueryPages(data)
}

return useInfiniteQuery({
queryKey: [
QueryKeys.InfiniteAlbums,
const sortOrder = [sortDescending ? SortOrder.Descending : SortOrder.Ascending]

const queryKey = [
QueryKeys.InfiniteAlbums,
isFavorites,
library?.musicLibraryId,
librarySortBy,
sortDescending,
yearMin,
yearMax,
]

const fetchPage = (pageNumber: number) =>
fetchAlbums(
api,
user,
library,
pageNumber,
isFavorites,
library?.musicLibraryId,
librarySortBy,
sortDescending,
[librarySortBy],
sortOrder,
yearMin,
yearMax,
],
queryFn: ({ pageParam }) =>
fetchAlbums(
api,
user,
library,
pageParam,
isFavorites,
[librarySortBy ?? ItemSortBy.SortName],
[sortDescending ? SortOrder.Descending : SortOrder.Ascending],
yearMin,
yearMax,
),
)

const infiniteQuery = useInfiniteQuery({
queryKey,
queryFn: ({ pageParam }) => fetchPage(pageParam),
initialPageParam: 0,
select: selectAlbums,
maxPages: MaxPages.Library,
Expand All @@ -88,6 +96,32 @@ const useAlbums = () => {
return firstPageParam === 0 ? null : firstPageParam - 1
},
})

const jumpToLetter = createLetterJump({
scope: {
endpoint: 'items',
params: {
parentId: library?.musicLibraryId,
includeItemTypes: [BaseItemKind.MusicAlbum],
userId: user?.id,
sortBy: [librarySortBy],
sortOrder,
isFavorite: isFavorites,
fields: [ItemFields.SortName],
recursive: true,
years: buildYearsParam(yearMin, yearMax),
},
},
sortDescending,
// Sections derive from SortName, so the NameLessThan count is exact
// only when the list is also SortName-ordered; Name/Album orders use
// the probe search instead
sortNameAligned: librarySortBy === ItemSortBy.SortName,
queryKey,
fetchPage,
})

return { infiniteQuery, jumpToLetter }
}

export default useAlbums
Expand Down
51 changes: 39 additions & 12 deletions src/api/queries/artist/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { QueryKeys } from '../../../enums/query-keys'
import { BaseItemDto, ItemSortBy, SortOrder } from '@jellyfin/sdk/lib/generated-client'
import { BaseItemDto, ItemFields, ItemSortBy, SortOrder } from '@jellyfin/sdk/lib/generated-client'
import { InfiniteData, useInfiniteQuery, useQuery } from '@tanstack/react-query'
import { isUndefined } from 'lodash'
import { fetchArtistFeaturedOn, fetchArtists } from './utils/artist'
Expand All @@ -11,6 +11,7 @@ import useLibraryStore from '../../../stores/library'
import { fetchItem } from '../item'
import { ArtistQueryKey } from './keys'
import { artistAlbumsQuery } from './queries'
import { createLetterJump } from '../letter-jump'

export const useArtist = (artistId: string | undefined | null) => {
const api = getApi()
Expand Down Expand Up @@ -46,21 +47,25 @@ export const useAlbumArtists = () => {
const sortDescending = librarySortDescendingState.artists ?? false
const isFavorites = filters.artists.isFavorites

const sortOrder = [sortDescending ? SortOrder.Descending : SortOrder.Ascending]

const selectArtists = (data: InfiniteData<BaseItemDto[], unknown>) => {
return flattenInfiniteQueryPages(data)
}

return useInfiniteQuery({
queryKey: [QueryKeys.InfiniteArtists, isFavorites, sortDescending, library?.musicLibraryId],
queryFn: ({ pageParam }: { pageParam: number }) =>
fetchArtists(
user,
library,
pageParam,
isFavorites,
[ItemSortBy.SortName],
[sortDescending ? SortOrder.Descending : SortOrder.Ascending],
),
const queryKey = [
QueryKeys.InfiniteArtists,
isFavorites,
sortDescending,
library?.musicLibraryId,
]

const fetchPage = (pageNumber: number) =>
fetchArtists(user, library, pageNumber, isFavorites, [ItemSortBy.SortName], sortOrder)

const infiniteQuery = useInfiniteQuery({
queryKey,
queryFn: ({ pageParam }: { pageParam: number }) => fetchPage(pageParam),
select: selectArtists,
maxPages: MaxPages.Library,
initialPageParam: 0,
Expand All @@ -71,4 +76,26 @@ export const useAlbumArtists = () => {
return firstPageParam === 0 ? null : firstPageParam - 1
},
})

const jumpToLetter = createLetterJump({
scope: {
endpoint: 'albumArtists',
params: {
parentId: library?.musicLibraryId,
userId: user?.id,
sortBy: [ItemSortBy.SortName],
sortOrder,
isFavorite: isFavorites,
fields: [ItemFields.SortName],
},
},
sortDescending,
// Artists are always SortName-ordered and section by SortName, so a
// single NameLessThan count resolves any letter exactly
sortNameAligned: true,
queryKey,
fetchPage,
})

return { infiniteQuery, jumpToLetter }
}
Loading
Loading