[SDK-701] End session for embedded with no impressions now reset the session - #1088
Open
franco-zalamena-iterable wants to merge 1 commit into
Open
[SDK-701] End session for embedded with no impressions now reset the session#1088franco-zalamena-iterable wants to merge 1 commit into
franco-zalamena-iterable wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🎟️ Jira Ticket: SDK-701
📖 Description
This PR fixes what was already modified on iOS for embedded sessions when they start and have no impressions when ending the session.
Before it would keep the open session until we got impressions, even on background or similar actions
Now if the endSession is called with no impressions we reset the session so it can start anew when necessary
🧪 How to test?
One test was modified from pinning the previous behaviour to the new one, the name is endSessionWithoutImpressionsEndsRunningSession
📚 Docs PR if applicable