Repository navigation
Conversation
It wasn't initializing the parameters from the genesis file, and so the forecasts had different values than the contemporary ledger state would, which violates the forecasting/LedgerView invariants. There are some other reasonable rules we could have added to make that harmless. For example, maybe nodes should not announce EBs in slots that don't have a Leios committee---it's a waste of diffusion work. This bug only bytes in the _first_ Dijkstra epoch, in which the Leios committee is necessarily empty. But no such rule was in place, so this would have resulted in honest nodes being unable to issue valid headers.
nfrisby
requested review from
bladyjoker,
dnadales,
geo2a and
jasagredo
as code owners
October 9, 2026 22:50
2 of 3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ch1bo pointed out that PR #2386 preserved this bug. Opening this quick follow-up PR to fix it.
It's a different fix than elsewhere, but I prefer this one: it means all cross-era Shelley forecasts still work in fundamentally the same way, this one just needs the config as an additional input that the existing LedgerView translations haven't needed.