Skip to content

Suggestions to #2386 - #2390

Closed
jasagredo wants to merge 10 commits into
nfrisby/leios-main-protofrom
js/nfrisby/leios-main-proto
Closed

Suggestions to #2386#2390
jasagredo wants to merge 10 commits into
nfrisby/leios-main-protofrom
js/nfrisby/leios-main-proto

Conversation

@jasagredo

@jasagredo jasagredo commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jasagredo
jasagredo force-pushed the js/nfrisby/leios-main-proto branch from 7e5c297 to 6d3ac4f Compare October 9, 2026 11:58
@ch1bo
ch1bo added this pull request to stack #2391 October 9, 2026 11:59
jasagredo
jasagredo commented Oct 9, 2026
View reviewed changes
Comment thread cabal.project
@ch1bo ch1bo added the Leios label Oct 9, 2026
@jasagredo
jasagredo force-pushed the js/nfrisby/leios-main-proto branch from 7d67af8 to f92c281 Compare October 9, 2026 14:12
@nfrisby

nfrisby commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Just for context:

  • This PR does adjust a couple things from my PR that it targets.
  • However, most of the content of this PR is integrating more cardano-ledger commits than my PR did---I ported the missing ledger feature to the latest release and developed against that. Javier instead found the unreleased commit on master that has the feature I need and then integrated all the other unrelated ledger changes into my PR. It's fine, but it's scope creep so I wanted to call it out. (But it's useful work that does have to happen before the next release, so doing it now is totally fine.)
  • Javier and I reviewed this on a call together.

@jasagredo
jasagredo force-pushed the js/nfrisby/leios-main-proto branch from f92c281 to f5a041f Compare October 9, 2026 14:28
@nfrisby

nfrisby commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

I cherry-picked your commits to my branch. (Aka I merged your PR, after fixing up my commits a tiny bit.) So: "Merged." Thanks!

@nfrisby nfrisby closed this Oct 9, 2026
An error occurred while trying to automatically change base from nfrisby/leios-main-proto to main October 9, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfrisby nfrisby Awaiting requested review from nfrisby nfrisby is a code owner
@dnadales dnadales Awaiting requested review from dnadales dnadales is a code owner
@geo2a geo2a Awaiting requested review from geo2a geo2a is a code owner
@bladyjoker bladyjoker Awaiting requested review from bladyjoker bladyjoker is a code owner

Assignees

No one assigned

Labels

Leios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasagredo @nfrisby @ch1bo