Repository navigation
Conversation
mgmeier
force-pushed
the
mkarg/fix-win-utf8
branch
from
October 9, 2026 12:19
fc0aa2b to
b72f5f3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #6711
On Windows,
cardano-nodewrote stdout and stderr in the system's legacy code page instead of UTF-8. This caused two problems:TraceOptionNodeName.The same crash occurs on Linux under a non-UTF-8 locale.
This PR wraps
maininwithCP65001 $ withUtf8incardano-node,cardano-tracerand thecardano-node-testsuite:withUtf8(from thewith-utf8package) makes the standard handles and the locale encoding UTF-8.withCP65001(from thecode-pagepackage) switches the Windows console code page to UTF-8 while the program runs.In the test suite this replaces the old stdout-only
hSetEncoding.Checklist
See Running tests for more details
CHANGELOG.mdfor affected packagecardano-node-chairman,cardano-submit-apiandcardano-testnetinstead need achangelog fragment in
<package>/.changes/, because theirCHANGELOG.mdis generatedfrom fragments at release time. Copy
_TEMPLATE.ymlfrom that directory, or runnix run github:input-output-hk/cardano-dev#herald -- new.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12