Skip to content

Build and inspect Dijkstra protected payments with Receiving witnesses - #1456

Closed
colll78 wants to merge 6 commits into
IntersectMBO:masterfrom
colll78:codex/cip-160-receiving
Closed

colll78 wants to merge 6 commits into
IntersectMBO:masterfrom
colll78:codex/cip-160-receiving

Adapt CLI ledger-state JSON to current snapshot schema

9fa3747
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / hlint succeeded Oct 7, 2026 in 3s

4 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 3 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 4 in cardano-cli/src/Cardano/CLI/EraBased/Script/Receiving/Read.hs

See this annotation in the file changed.

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-cli/src/Cardano/CLI/EraBased/Script/Receiving/Read.hs:4:1-27: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE LambdaCase #-}
  
Perhaps you should remove it.

Check notice on line 386 in cardano-cli/src/Cardano/CLI/Type/Common.hs

See this annotation in the file changed.

Code scanning / HLint

Use tuple-section Note

cardano-cli/src/Cardano/CLI/Type/Common.hs:386:27-51: Suggestion: Use tuple-section
  
Found:
  \ deposit -> (pp, deposit)
  
Perhaps:
  (pp,)
  
Note: may require {-# LANGUAGE TupleSections #-} adding to the top of the file

Check notice on line 389 in cardano-cli/src/Cardano/CLI/Type/Common.hs

See this annotation in the file changed.

Code scanning / HLint

Use tuple-section Note

cardano-cli/src/Cardano/CLI/Type/Common.hs:389:12-42: Suggestion: Use tuple-section
  
Found:
  \ deposit -> (futurePp, deposit)
  
Perhaps:
  (futurePp,)
  
Note: may require {-# LANGUAGE TupleSections #-} adding to the top of the file

Check notice on line 393 in cardano-cli/test/cardano-cli-test/Test/Cli/Transaction/Receiving.hs

See this annotation in the file changed.

Code scanning / HLint

Use lambda-case Note test

cardano-cli/test/cardano-cli-test/Test/Cli/Transaction/Receiving.hs:(389,13)-(393,28): Suggestion: Use lambda-case
  
Found:
  \ witness
    -> case witness of
         ShelleyKeyWitness _ wit
           -> do H.assert (verifyWitVKey originalHash wit)
                 H.assert (not (verifyWitVKey changedHash wit))
         _ -> H.failure
  
Perhaps:
  \case
    ShelleyKeyWitness _ wit
      -> do H.assert (verifyWitVKey originalHash wit)
            H.assert (not (verifyWitVKey changedHash wit))
    _ -> H.failure
  
Note: may require {-# LANGUAGE LambdaCase #-} adding to the top of the file