Repository navigation
Use CHaP network releases for miniprotocol filtering - #1384
Merged
Merged
Conversation
Jimbo4350
requested review from
CarlosLopezDeLara,
carbolymer,
disassembler,
erikd and
palas
as code owners
October 20, 2026 20:01
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Compatibility with the pinned networking dependencies still requires CI build and test validation.
No open issues 🎉
What changed in this PR
Temporarily pins networking dependencies to upstream PR 5460 for miniprotocol filtering.
Changes:
- Pins
ouroboros-networkandcardano-diffusionto commit8466558, including a Nix source hash. - Adds a maintenance changelog fragment.
| File | Description |
|---|---|
cabal.project |
Adds the temporary dependency pin and source hash. |
.changes/20261020_cardano-api_ouroboros_network_5460.yml |
Records the dependency change for cardano-api. |
Review effort: Balanced
Jimbo4350
added a commit
that referenced
this pull request
Oct 20, 2026
Require ouroboros-network 2.0 and pin cardano-diffusion and network-mux to the same revision, with temporary dependency-bound relaxations. Select matching macOS Command Line Tools for CI and add the maintenance changelog for PR #1384.
Jimbo4350
force-pushed
the
srp/ouroboros-network-5460
branch
from
October 20, 2026 20:44
29fb10c to
17c4c68
Compare
Jimbo4350
added a commit
that referenced
this pull request
Oct 22, 2026
Require ouroboros-network 2.0 and advance the CHaP index and Nix input to use the released ouroboros-network, cardano-diffusion and network-mux packages. Retain the dependency-bound relaxations pending upstream updates. Select matching macOS Command Line Tools for CI and add the maintenance changelog for PR #1384.
Jimbo4350
force-pushed
the
srp/ouroboros-network-5460
branch
from
October 22, 2026 12:30
17c4c68 to
75a6661
Compare
carbolymer
approved these changes
Oct 22, 2026
Jimbo4350
added a commit
that referenced
this pull request
Oct 22, 2026
Require ouroboros-network 2.0 and advance the CHaP index and Nix input to use the released ouroboros-network, cardano-diffusion and network-mux packages. Retain the dependency-bound relaxations pending upstream updates and add the maintenance changelog for PR #1384.
Jimbo4350
force-pushed
the
srp/ouroboros-network-5460
branch
from
October 22, 2026 12:57
75a6661 to
cc6456a
Compare
Jimbo4350
added a commit
that referenced
this pull request
Oct 22, 2026
Require ouroboros-network 2.0 and advance the CHaP index and Nix input to use the released ouroboros-network, cardano-diffusion and network-mux packages. Retain the dependency-bound relaxations pending upstream updates and add the maintenance changelog for PR #1384.
Jimbo4350
force-pushed
the
srp/ouroboros-network-5460
branch
from
October 22, 2026 14:17
cc6456a to
f594102
Compare
Jimbo4350
added a commit
that referenced
this pull request
Oct 22, 2026
Require ouroboros-network 2.0 and advance the CHaP index and Nix input to use the released ouroboros-network, cardano-diffusion and network-mux packages. Retain the dependency-bound relaxations pending upstream updates and add the maintenance changelog for PR #1384. Use grpc-deps 0.0.2.0 so Windows installs protobuf and snappy for CLANG64 and exposes protoc and the runtime DLLs through PATH, matching the base dependencies action.
Jimbo4350
force-pushed
the
srp/ouroboros-network-5460
branch
from
October 22, 2026 15:07
f594102 to
80aff31
Compare
Jimbo4350
enabled auto-merge
October 22, 2026 15:23
Jimbo4350
added a commit
that referenced
this pull request
Oct 22, 2026
Require ouroboros-network 2.0 and advance the CHaP index and Nix input to use the released ouroboros-network, cardano-diffusion and network-mux packages. Retain the dependency-bound relaxations pending upstream updates and add the maintenance changelog for PR #1384. Use grpc-deps 0.0.2.0 so Windows installs protobuf and snappy for CLANG64 and exposes protoc and the runtime DLLs through PATH, matching the base dependencies action.
Jimbo4350
force-pushed
the
srp/ouroboros-network-5460
branch
from
October 22, 2026 15:59
80aff31 to
b7b0bac
Compare
Require ouroboros-network 2.0 and advance the CHaP index and Nix input to use the released ouroboros-network, cardano-diffusion and network-mux packages. Retain the dependency-bound relaxations pending upstream updates and add the maintenance changelog for PR #1384. Use grpc-deps 0.0.2.0 so Windows installs protobuf and snappy for CLANG64 and exposes protoc and the runtime DLLs through PATH, matching the base dependencies action.
Jimbo4350
force-pushed
the
srp/ouroboros-network-5460
branch
from
October 22, 2026 16:40
b7b0bac to
2052ab2
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 22, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Require
ouroboros-network2.0 for miniprotocol filtering from IntersectMBO/ouroboros-network#5460. Advance the CHaP index to2026-10-22T08:15:23Zand update the CHaP Nix input so the build uses the publishedouroboros-network-2.0.0.0,cardano-diffusion-1.3.0.1, andnetwork-mux-1.0.0.0packages.The temporary network source-repository-package override is removed. Keep the targeted dependency-bound relaxations for
cardano-config,kes-agent, andouroboros-consensus: their published bounds still exclude the new network releases.Update the gRPC dependency action to
grpc-deps-0.0.2.0so Windows installs protobuf and snappy for CLANG64, matching the base dependencies action, and adds their executable/DLL directory toPATH. This fixes the missingprotocfailure while buildingproto-lens-protobuf-types.On Windows, use
snappy-c'spkg-configflag and clear the globalLIBRARY_PATH/CPATHoverrides from the gRPC action. This scopes MSYS2 discovery to Snappy instead of overriding GHC's C++ runtime during Template Haskell compilation. Retain failed Windows Cabal logs as CI artifacts for diagnosis.How to trust this PR
2052ab23f: builds and tests pass on Linux with GHC 9.6, 9.10, 9.12 and 9.14, macOS with GHC 9.6, and Windows with GHC 9.12.cardano-rpctests.actionlint .github/workflows/haskell.ymlpasses locally and in CI; all PR checks pass.git diff --checkpasses; the Herald description occupies one physical line.Checklist
.changes/