Repository navigation
Bump herald-release to 0.0.3.1 - #1367
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The required changelog fragment is missing.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates the release workflow to use herald-release 0.0.3.1, fixing CHaP commit resolution for annotated tags.
Changes:
- Bumps the pinned action from 0.0.3.0 to 0.0.3.1.
| File | Description |
|---|---|
.github/workflows/release.yml |
Updates the Herald release action version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| accept-flake-config = true | ||
|
|
||
| - uses: input-output-hk/cardano-dev/actions/herald-release@herald-release-0.0.3.0 | ||
| - uses: input-output-hk/cardano-dev/actions/herald-release@herald-release-0.0.3.1 |
palas
approved these changes
Oct 6, 2026
palas
left a comment
palas
left a comment
Contributor
There was a problem hiding this comment.
Yes, probably for the best. I've seen tags end up as broken links in the CHaP webpage. 👍
carbolymer
enabled auto-merge
October 7, 2026 06:12
carbolymer
disabled auto-merge
October 7, 2026 06:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Bumps the
herald-releaseaction used in.github/workflows/release.ymlfromherald-release-0.0.3.0toherald-release-0.0.3.1.The new herald-release fixes the CHaP submission snippet that gets embedded in release PR bodies.
The snippet resolved a release tag to a commit hash with
git ls-remote <repo> refs/tags/<tag>.For signed or annotated tags, that command returns the tag object's own hash rather than the commit hash, so the hash passed on to CHaP's add-from-github.sh was never a commit.
The snippet now resolves the tag to the commit it points to, for both annotated and lightweight tags.
References:
No changelog fragment is needed for this PR.
Herald's
--diffcheck only requires a fragment for a project when a changed file sits under that project's directory, and.github/sits outside all of cardano-api's projects.How to trust this PR
The only change is the pinned action version in
.github/workflows/release.yml.The fix was verified in the cardano-dev repository itself; the next cardano-api release run that produces a CHaP submission snippet exercises the corrected tag resolution.
Checklist
.changes/