fix(cuda/gemm): make caches safe for threaded callers#632
Open
voltjia wants to merge 1 commit into
Open
Conversation
38eae03 to
80fa335
Compare
Collaborator
Author
|
Update after review request:
Latest remote NVIDIA validation, container Also reran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/native/cuda/ops/gemm/blas.hso CUDA GEMM uses one thread-local BLAS handle cache per device index instead of a single process-wide handle.src/operator.hsoOperator::Calluses thread-local operator cache storage with an atomic generation counter for cache invalidation.tests/test_cpp_api.pywith a multi-threaded public C++Operator::Callsmoke check.Motivation
Closes #627
Downstream multi-thread and multi-device callers can call public C++
Operator::Callconcurrently. The previous process-wide operator cache was unsynchronized, and CUDA GEMM used one process-wide BLAS handle. This PR removes those shared mutable process-wide caches from the hot path.The previous draft also changed NVIDIA fp32 GEMM compute type. That change has been removed because it is not necessary for this cache/thread-safety fix.
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
pytestResult2000 passed, 1001 skipped in 12.46snvidia, containerinfiniops-ci/nvidia:latest,WITH_CPU=ON,WITH_NVIDIA=ONFull `pytest` output (optional)
Benchmark / Performance Impact
N/A. This PR changes cache ownership for thread safety; no benchmark was run.
Notes for Reviewers
BlasGemm::GetHandlenow keys BLAS handles byTensor::device().index()within each host thread.Operator::Callcache entries are no longer shared between host threads.clear_cache()still invalidates each thread's cache on that thread's next call by using a shared atomic generation counter.Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `seqlens_k` tensor) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 21, per.github/workflows/clang-format.yml) has been run against all modified.h,.cc,.cuh, and.mlufiles; the diff is clean. Not run: clang-format 21 was not available in the NVIDIA validation container.clang-tidyconcerns (per.clang-tidy) have been reviewed — no new warnings beyond the existing baseline.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).new/delete; RAII / smart pointers / existing allocators are used.Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.pytest.skipmessages without terminal period) are honored where applicable (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement (CONTRIBUTING.md§Python).Testing
pytestwas run locally on every supported platform that this PR can affect, and the results are recorded in the "Test Results" table above (CONTRIBUTING.md§Pull Requests). Only NVIDIA was run for this PR update.tests/followingtests/test_add.py/tests/test_gemm.pypatterns (CONTRIBUTING.md§Adding an Operator).pytest.mark.parametrizecorrectly: dependent parameters share one decorator (e.g.@pytest.mark.parametrize("dtype, rtol, atol", …)), independent parameters use separate decorators ordered by parameter declaration.Payload.dtype/deviceparameterization is relied on, or overridden with an explicitpytest.mark.parametrizewhen necessary.pytest -n 1.masterand passes with this PR.Build, CI, and Tooling
pip install .[dev]on at least one affected platform. Built withpip install --no-build-isolation --no-deps .in the NVIDIA CI container.compile_commands.jsonstill regenerates (CMake optionCMAKE_EXPORT_COMPILE_COMMANDS=ONinpyproject.toml— required by thecode-lintskill andclang-tidy -p).CMakeLists.txtis not broken.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).ruffwas run locally in the container; clang-format 21 was not available.pyproject.toml's[project.optional-dependencies](or justified in the PR description).Documentation
Security and Safety