ci: fix platform-specific builds#630
Draft
zhangyue207 wants to merge 1 commit into
Draft
Conversation
2b6a938 to
2d1da72
Compare
2d1da72 to
55db437
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WITH_CPU=ONplus its targetWITH_<PLATFORM>=ONwithAUTO_DETECT_DEVICES=OFF.operator_call_instantiations_*.ccsources.__kmpc_*symbols from Moore-compiled objects.Motivation
Several PRs based on
3371c14expose platform failures that are not caused by the operator PR diffs:operator_call_instantiations_*.ccCUDA translation units compile concurrently with pybind binding unity sources after public C++ operator call instantiations were added.infini.opswithundefined symbol: __kmpc_for_static_fini.Closes #
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
pytestResultFull `pytest` output (optional)
Benchmark / Performance Impact
N/A. The generated operator-call instantiation job pool only caps the heavyweight generated instantiation sources; it does not globally limit the whole build.
Notes for Reviewers
This PR intentionally avoids setting global build parallelism through
CMAKE_BUILD_PARALLEL_LEVELorMAX_JOBS. The concurrency cap is scoped to generated operator-call instantiation sources, matching the new heavy source class added by public C++ operator-call instantiation generation.Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `seqlens_k` tensor) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
N/A. No C++ source files changed.
Python Specific (if Python files changed)
N/A. No Python files changed.
Testing
pytestwas run locally on every supported platform that this PR can affect, and the results are recorded in the "Test Results" table above (CONTRIBUTING.md§Pull Requests).Build, CI, and Tooling
pip install .[dev]on at least one affected platform.compile_commands.jsonstill regenerates (CMake optionCMAKE_EXPORT_COMPILE_COMMANDS=ONinpyproject.toml— required by thecode-lintskill andclang-tidy -p).clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).pyproject.toml's[project.optional-dependencies](or justified in the PR description).Documentation
N/A. This change adjusts CI/build plumbing only.
Security and Safety