Skip to content

feat(color-picker): Initial theming commit - #2316

Open
desig9stein wants to merge 11 commits into
rkaraivanov/color-pickerfrom
mpopov/color-picker-styling
Open

feat(color-picker): Initial theming commit#2316
desig9stein wants to merge 11 commits into
rkaraivanov/color-pickerfrom
mpopov/color-picker-styling

Conversation

@desig9stein

@desig9stein desig9stein commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

The PR should be tested with the theming package from this PR

  • Add support for Fluent, Material, Bootstrap, and Indigo themes.
  • Introduce shared styles for consistency across themes.
  • Integrate light and dark theme support with theming controllers.
  • Refactor base styles and optimize CSS structure.

Description

Provide a clear and concise summary of the changes in this PR and the motivation behind them

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to change)
  • Documentation update
  • Refactoring (code improvements without functional changes)

Related Issues

Closes #

Testing

Checklist

  • My code follows the project's coding standards
  • I have tested my changes locally
  • I have updated documentation if needed
  • Breaking changes are documented in the description

- Add support for Fluent, Material, Bootstrap, and Indigo themes.
- Introduce shared styles for consistency across themes.
- Integrate light and dark theme support with theming controllers.
- Refactor base styles and optimize CSS structure.
- Refine theme-specific styles for Fluent, Material, Bootstrap, and Indigo.
- Introduce mixins for shared slider tracks, swatch previews, and buttons.
- Update anchor styling with hover, focus, and invalid states.
- Improve responsiveness with grid-based layouts for picker elements.
- Optimize rendering logic for anchors and input modes.
- Add new tests for empty anchor state handling.
- Replace outline icon buttons with flat variants; add `eye_dropper` icon.
- Refactor grid-based layouts with new CSS variables for improved responsiveness.
- Enhance marker styling with opacity control and focus animation.
- Update swatches to use grid layout for better spacing and alignment.
- Introduce new tests for marker fill and opacity consistency.
- Adjust canvas and picker styles for clearer structure and customization.
- Refactor and align SCSS indentation across files for consistency.
- Replace duplicate/custom values with shared theme vars/mixins.
- Update `--_marker-color` to `--_marker-fill` for clarity and code clarity.
- Apply minor layout and styling tweaks across themes.
…nsistency and functionality

- Optimize focus styling for anchors, adjusting width, height, and border-radius calculations.
- Refactor slider-thumb mixin to accept a `$fill` parameter for better versatility.
- Enhance swatch preview and transparency grid styling for clarity and alignment.
- Replace deprecated variables with centralized theme tokens for improved maintainability.
- Update theming controller logic and improve color update handling.
- Adjust layout grid and spacing for better responsiveness.
@sdimchevski sdimchevski assigned sbayreva and unassigned sdimchevski Aug 10, 2026
…ariable

- Replace `gap` with `row-gap` for better alignment.
- Remove `--_swatches-col-gap`, update swatches to a fixed column count.
@desig9stein
desig9stein force-pushed the mpopov/color-picker-styling branch from 73aa03e to 27eae29 Compare August 11, 2026 12:56
@adrianptrv

Copy link
Copy Markdown
Contributor

When the Color Picker is in input mode and we use the outlined Material input, the border goes above the label without a notch when the input is empty and the Color Picker is opened. Once a color is selected and the input is filled, the notch appears.

Screenshot 2026-08-12 at 15 01 09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants