feat(*): add theming widget handling - #1093
Open
ChronosSF wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for remotely re-theming the samples browser when it’s embedded in the docs site, by listening for a trusted postMessage and dynamically swapping Ignite UI theme stylesheets.
Changes:
- Introduces
sample-theme.tsto validate theme messages, resolve light/dark/system mode, and load the corresponding theme CSS via dynamic imports. - Initializes the theme message listener during app startup in
browser/src/index.tsxso the host can re-post theme selection on iframe load.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| browser/src/sample-theme.ts | Adds message validation + dynamic CSS loading to apply Ignite UI theme/mode inside an embedded iframe. |
| browser/src/index.tsx | Initializes the new theme listener during app entry module evaluation. |
Suppressed comments (1)
browser/src/sample-theme.ts:93
parseMessagereturnsnullin several branches but its return type doesn’t allownull, and it calls.toLowerCase()on potentially non-string values frompostMessage(which can throw and break the message handler). Adjust the signature to return| nulland defensively coerce/validate the incoming fields before lowercasing.
function parseMessage(data: any): { theme: ThemeName; mode: ThemeMode } {
if (!data || typeof data !== 'object') { return null; }
const msg = data as ThemeMessage;
if (msg.type !== MESSAGE_TYPE && msg.event !== MESSAGE_TYPE) { return null; }
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+72
to
+74
| const styleEls: HTMLStyleElement[] = []; | ||
| let selected: { theme: ThemeName; mode: ThemeMode } = null; | ||
| let latestRequest = 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.