-
Notifications
You must be signed in to change notification settings - Fork 558
fix: possible locally fair dataset download fix #12581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
srmanda-cs
wants to merge
2
commits into
IQSS:develop
from
uncch-rdmc:12579-locally-fair-dataset-ui-download-fix
+6
−0
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending IQSS team review and suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix takes the right approach, but I think this is too broad, as it affects all APIs and is essentially the same as https://guides.dataverse.org/en/latest/installation/config.html#dataverse-feature-api-session-auth, with the same risk noted in the Guides. (Nominally a work-around for testing LFAIR though). The access apis are special in that they are the only ones called from the JSF UI directly, so we need to allow session auth just for them even when the flag is off. This is currently being handled in a few related Access methods - see
dataverse/src/main/java/edu/harvard/iq/dataverse/api/Access.java
Lines 2284 to 2299 in 0a49c4c
dataverse/src/main/java/edu/harvard/iq/dataverse/api/Access.java
Lines 2237 to 2268 in 0a49c4c
We probably need to discuss this more, but I might suggest we simplify by just exempting the access apis in https://github.com/IQSS/dataverse/blob/develop/src/main/java/edu/harvard/iq/dataverse/api/auth/SessionCookieAuthMechanism.java which should resolve this issue, and the private URL one and clean up the code. I'll put this in triage so this gets on the radar Monday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed review and context!
My original fix was definitely intended as a minimal proof-of-concept to get the root cause and a workaround on the team's radar.
Your suggestion to handle this at the SessionCookieAuthMechanism level makes a lot of sense. I am happy to pause or close this PR and let the team discuss the best path forward.