-
Notifications
You must be signed in to change notification settings - Fork 558
Review Datasets #11753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Review Datasets #11753
Changes from 29 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
bf0f63e
add "review" dataset type #11747
pdurbin 0a48cc8
only populate Related Dataset and only HTML version #11747
pdurbin d287907
add blocks for Trusted Data and Repo Characteristics #11747
pdurbin c938a7a
Adding properties files for two metadata blocks
jggautier 1c73793
add displayName for datasetType #11747 #11887
pdurbin 9138524
have displayname default to empty string #11747
pdurbin e6447b7
when creating dataset types, allow displayName #11747
pdurbin 99fcede
allow i18n of displayName for dataset types #11747
pdurbin a7608e9
rename sql script
pdurbin e6fa18c
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 016929c
remove metadata blocks use for demo
pdurbin c60359a
add review metadata block and tests #12015
pdurbin b49b522
add properties file for review metadata block #12015
pdurbin 3de3913
add description for dataset types #11887 #11747
pdurbin d54ae98
add description of dataset to properties file #11887 #11747
pdurbin ef981f3
control over which dataset types are available, per collection #12115
pdurbin 2a725c8
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 6c9df72
explain that deleting dataset type by name is not supported #11833
pdurbin 467a05d
use machine-readable names under the "Dataset Type" facet #11758
pdurbin 90346e4
address code review, link to table #11747
pdurbin 6994e22
for CSL citation, type can be dataset, software, or review #11747
pdurbin 3895cd6
remove refs to blocks deleted in 016929ca9 #11747
pdurbin 20f9bb6
add docs for review datasets, update docs for dataset types #11747
pdurbin b8b4a07
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 8091c45
assert resourceTypeGeneral=Other for review datasets #11747
pdurbin e65d76d
send <resourceType resourceTypeGeneral="Other">Review to DataCite #11747
pdurbin e2ec594
Merge branch 'develop' into 11747-review-dataset-type
pdurbin d2f12df
switch allowedDatasetTypes in entity from String to a ManyToMany List…
pdurbin 060215f
improve description of a dataset
pdurbin ca8a7c6
shorten description of dataset and match properties file
pdurbin 8280947
cleanup: logging, javadoc, and comments #11747
pdurbin f48b48e
rename class: first character upper case
pdurbin 403a32d
a description for "review" dataset type
pdurbin 6481526
update description for a review #11747
pdurbin 5165d20
Merge branch 'develop' into 11747-review-dataset-type
pdurbin a1bca73
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 1992849
Merge branch 'develop' into 11747-review-dataset-type
pdurbin c3b4de6
let VS Code generate hashCode and equals
pdurbin b0b9b13
add test for empty string passed to allowedDatasetTypes
pdurbin cc5b11d
populate displayname with name but capitalize it
pdurbin ce4a48f
typo
pdurbin be670d4
allow regular and review datasets the same collection #11747
pdurbin 8f2ad13
remove note as we are using linkedMetadataBlocks now #11747
pdurbin 32adb99
improve "add dataset type" docs #11747
pdurbin 988e316
Apply suggestions from code review
pdurbin 6279e4f
tweak docs
pdurbin 9b5d4eb
add comment about non-use of PeerReview #11747
pdurbin f561a07
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 9c4e398
clean up test code
pdurbin 050439d
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 2b03a64
better handling of collections disallowing "dataset" datasetType #121…
pdurbin 38ec9a7
move "create collection" step down, just before "allow type" #11747
pdurbin bebb87b
add sample file dataset-create-review.json #11747
pdurbin 169aa00
Merge branch 'develop' into 11747-review-dataset-type
pdurbin f66fa60
add test for required fields in a metadata block tsv #11747
pdurbin 92c95e6
link dataset type properly in test (fix typo) #11747
pdurbin f215ba6
Merge branch 'develop' into 11747-review-dataset-type
pdurbin 943875c
make itemReviewedCitation required #11747
pdurbin 4d71ae2
link to linkedMetadataBlocks required in tsv issue
pdurbin 4da6d9f
better citation for item reviewed
pdurbin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| ## Highlights | ||
|
|
||
| ### Review Datasets | ||
|
|
||
| Dataverse now supports review datasets, a type of dataset that can be used to review resources such as other datasets in the Dataverse installation itself or various resources in external data repositories. APIs and a new "review" metadata block (with an "Item Reviewed" field) are in place but the UI for this feature will only available in a future version of the new React-based [Dataverse Frontend](https://github.com/IQSS/dataverse-frontend). See also the [guides](https://dataverse-guide--11753.org.readthedocs.build/en/11753/api/native-api.html#add-dataset-type), #11747, #12015, #11887, #12115, and #11753. | ||
|
|
||
| ## Other Features Added | ||
|
|
||
| - Citation Style Language (CSL) output now includes "type:software" or "type:review" when those dataset types are used. See the [guides](https://dataverse-guide--11753.org.readthedocs.build/en/11753/api/native-api.html#get-citation-in-other-formats) and #11753. | ||
|
|
||
| ## Updated APIs | ||
|
|
||
| - The Change Collection Attributes API now supports `allowedDatasetTypes`. See the [guides](https://dataverse-guide--11753.org.readthedocs.build/en/11753/api/native-api.html#change-collection-attributes), #12115, and #11753. | ||
|
|
||
| ## Bugs Fixed | ||
|
|
||
| - 500 error when deleting dataset type by name. See #11833 and #11753. | ||
| - Dataset Type facet works in JSF but not the SPA. See #11758 and #11753. | ||
|
|
||
| ## Backward Incompatible Changes | ||
|
|
||
| ### Dataset Types Must Be Allowed, Per-Collection, Before Use | ||
|
|
||
| In previous releases of Dataverse, as soon as additional dataset types were added (such as "software", "workflow", etc.), they could be used by all users when creating datasets (via API only). As of this release, on a per-collection basis, superusers must allow these dataset types to be used. See #12115 and #11753. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sentence doesn't quite make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I forgot an "if". Added in ce4a48f.