You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Configured Publish Dataset modal text is now rendered as HTML, matching the configuration intent. The markup is sanitized with DOMPurify before parsing, and component coverage verifies links and line breaks.
The sanitization step prevents configured markup from injecting unsafe content. Chromatic and label-copy checks cannot access fork secrets/permissions; those fork-only failures are expected.
Suggestions on how to test this:
Configure publish modal text containing a link and a line break.
Open the Publish Dataset modal and confirm both render as HTML.
Run the focused PublishDatasetModal component spec; all 14 tests pass locally.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes. Configured modal markup now renders as intended; no mockup is required.
Is there a release notes or changelog update needed for this change?:
No separate release note is included.
Additional documentation:
No additional documentation is required.
Verification: focused component tests (14 passing), lint (four pre-existing unrelated warnings), production build, and diff check.
Merged current develop and resolved the additive changelog conflict on head bd18010482e08f9c87caaec0c5cabb56977c7c19. Relative to current develop, the PR still changes only the changelog, PublishDatasetModal.tsx, and its component spec. Exact-head local verification: focused component spec 14/14 passing, npm run lint passing with four pre-existing unrelated warnings, production build passing, and staged git diff --check passing.
The fresh GitHub Actions runs for exact head bd18010482e08f9c87caaec0c5cabb56977c7c19 are currently classified as action_required with no jobs, which is a maintainer-controlled fork workflow approval gate rather than a code failure. Could a maintainer approve the workflow run when convenient? The focused test, lint, build, and diff checks are already recorded above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Configured Publish Dataset modal text is now rendered as HTML, matching the configuration intent. The markup is sanitized with DOMPurify before parsing, and component coverage verifies links and line breaks.
Which issue(s) this PR closes:
Special notes for your reviewer:
The sanitization step prevents configured markup from injecting unsafe content. Chromatic and label-copy checks cannot access fork secrets/permissions; those fork-only failures are expected.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes. Configured modal markup now renders as intended; no mockup is required.
Is there a release notes or changelog update needed for this change?:
No separate release note is included.
Additional documentation:
No additional documentation is required.
Verification: focused component tests (14 passing), lint (four pre-existing unrelated warnings), production build, and diff check.