-
Notifications
You must be signed in to change notification settings - Fork 25
Guestbook Edit and Guestbook Response Integration #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChengShi-1
wants to merge
24
commits into
ManageGuestbook
Choose a base branch
from
1002-edit-guestbook-and-guestbook-responses-integration
base: ManageGuestbook
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2c79b64
feat: add file citation download
ChengShi-1 19b8624
update changelog
ChengShi-1 e5442a5
Merge branch 'develop' into CiteDataFile-Integration
ChengShi-1 4eecfeb
update package
ChengShi-1 1d9a1e4
Merge branch 'develop' into CiteDataFile-Integration
ChengShi-1 25e1368
feat: add edit guestbook use case, and apply GuestbookDTO to both edi…
ChengShi-1 5518176
feat: edit guestbook integration
ChengShi-1 b53808d
feat: guestbook response page
ChengShi-1 f8853d5
Merge branch 'ManageGuestbook' into 1002-edit-guestbook-and-guestbook…
ChengShi-1 e0c57c5
fix: increase test coverage
ChengShi-1 ca340f6
fix: e2e test error
ChengShi-1 cc8dd2f
fix: make guestbooks enabled by default
ChengShi-1 260297d
feat: copy guestbook action button
ChengShi-1 6c547a6
fix: accessibility test error
ChengShi-1 1839bd6
fix: Lint error
ChengShi-1 fd320fc
fix: update guestbookDTO
ChengShi-1 c9e321e
Merge branch 'ManageGuestbook' into 1002-edit-guestbook-and-guestbook…
ChengShi-1 d62152e
fix: copilot review
ChengShi-1 97cddaa
Merge with develop branch
ChengShi-1 e504ed5
Merge branch 'develop' into CiteDataFile-Integration
ChengShi-1 228cd56
Merge pull request #995 from IQSS/CiteDataFile-Integration
sekmiller fd0d679
Merge pull request #992 from IQSS/ManageGuestbook
sekmiller 9e82b53
Merge branch 'develop' of https://github.com/IQSS/dataverse-frontend …
ChengShi-1 d740540
fix: unit test
ChengShi-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| export enum FileCitationFormat { | ||
| Internal = 'Internal', | ||
| EndNote = 'EndNote', | ||
| RIS = 'RIS', | ||
| BibTeX = 'BibTeX', | ||
| CSLJson = 'CSL' | ||
| } | ||
|
|
||
| export interface FormattedFileCitation { | ||
| content: string | ||
| contentType: string | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { FormattedFileCitation, FileCitationFormat } from '../models/FileCitation' | ||
| import { FileRepository } from '../repositories/FileRepository' | ||
|
|
||
| export function getFileCitationByFormat( | ||
| fileRepository: FileRepository, | ||
| fileId: string | number, | ||
| format: FileCitationFormat | ||
| ): Promise<FormattedFileCitation> { | ||
| return fileRepository.getFileCitationByFormat(fileId, format) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/guestbooks/domain/models/GuestbookResponsesPaginationInfo.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { PaginationInfo } from '@/shared/pagination/domain/models/PaginationInfo' | ||
|
|
||
| export class GuestbookResponsesPaginationInfo extends PaginationInfo<GuestbookResponsesPaginationInfo> { | ||
| constructor(page = 1, pageSize = 10, totalItems = 0, itemName = 'Response') { | ||
| super(page, pageSize, totalItems, itemName) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { GuestbookQuestionType } from '../../models/Guestbook' | ||
|
|
||
| export interface GuestbookDTO { | ||
| name: string | ||
| enabled: boolean | ||
| emailRequired: boolean | ||
| nameRequired: boolean | ||
| institutionRequired: boolean | ||
| positionRequired: boolean | ||
| createTime?: string | ||
| customQuestions?: GuestbookCustomQuestionDTO[] | ||
| } | ||
|
|
||
| export interface GuestbookCustomQuestionDTO { | ||
| id?: number | ||
| question: string | ||
| required: boolean | ||
| displayOrder: number | ||
| type: GuestbookQuestionType | ||
| hidden: boolean | ||
| optionValues?: GuestbookOptionDTO[] | ||
| } | ||
|
|
||
| export interface GuestbookOptionDTO { | ||
| id?: number | ||
| value: string | ||
| displayOrder: number | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.