Repository navigation
Fix release 1 0 0 issues - #6
Merged
Merged
Conversation
The ServiceRequest.identifier slicing used a value discriminator at type.coding, but the placer/filler slices fixed their distinguishing values (PLAC/FILL) one level deeper on a nested type.coding sub-slice. The validator could not evaluate the discriminator, making any ServiceRequest that populated placer or filler unvalidatable and cascading to ImagingStudy.basedOn, Composition.event, and the Bundle composition/imaging-study entry slices (11 of 32 build errors). Switch to a pattern discriminator on `type` with a patternCodeableConcept per slice: - placer -> type = v2-0203#PLAC - filler -> type = v2-0203#FILL - accession-number -> add type = v2-0203#ACSN directly on the slice, since the validator does not read the pattern from the referenced MadoAccessionNumberIdentifier profile. Add MadoRequestedProcedureExample, a standalone ServiceRequest example exercising all three identifier slices. Existing example bundles are left unchanged. Build: SUSHI 0/0; IG Publisher errors 32 -> 1 (only the known upstream xver inconsistent-canonical error remains).
…fhir.uv.xver-r5.r4#0.1.0 Bump the xver dependency from 0.0.1-snapshot-2 to 0.1.0, which also clears the persistent "inconsistent canonical" IG-publisher error. 0.1.0 keeps the http://hl7.org/fhir/5.0/... extension canonicals but changed internal structures: - content.profile: reused from 0.1.0; inner sub-slice renamed value[x] -> value. - bodySite: 0.1.0 models it as Reference-only (drops the CodeableConcept concept used here), so it is imported locally (MadoDocumentReferenceBodySite). - modality: absent from 0.1.0, imported locally (MadoDocumentReferenceModality). Repoint the bodySite/modality aliases, SearchParameter expressions and example resources at the local extensions; drop the obsolete xver canonical suppression and suppress the pedantic concept FHIRPath hint. Build: SUSHI 0/0; IG Publisher Errors 0, Warnings 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(fsh): resolve release 1.0.0 profile validation issues