Fix config initialization, serialization, pipeline compatibility, and Apple MPS GPU compatibility - #29
Open
gokulrejith wants to merge 1 commit into
Open
Conversation
… MPS support Signed-off-by: Gokul Rejithkumar <gokulrejith@gmail.com>
gokulrejith
force-pushed
the
fix/save-and-inference-issues
branch
from
July 24, 2026 11:42
50a9e9b to
48cb2ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several functional bugs that crash the model during standard inference and loading workflows:
input_idsandattention_maskand do not provide labels during inference. Added fallback mapping for these arguments and graceful handling oflabels=Noneby returning aSequenceClassifierOutputcontaining logits, which prevents the pipeline from crashing.FastFitConfigstrictly asserted an encoder config was provided. Made encoder optional to comply with Hugging Face's zero-argument config instantiation rules.SupConLoss: Replaced the hardcoded cuda vs cpu fallback with dynamic device detection (features.device), preventing a crash on Apple Silicon (MPS) and other architectures.FloatTensorinstead ofDoubleTensorduring the fallback loss calculation and explicitly sent them toself.deviceto prevent precision and device mismatch runtime errors on GPUs.