SCENARIO: Page title should be updated when the user goes back to the bookshelf (see #174)#391
Conversation
Corrected the title of the tab
|
@AdePeti @gd-utt @Lysakolie Thank you for your contribution. Your git history has to be edited so that, for scenarios, you have:
I strongly recommend using Git Fork for the intensive git history rewriting done in IF05. |
benel
left a comment
benel
left a comment
There was a problem hiding this comment.
Thank you for your contribution @AdePeti @gd-utt @Lysakolie
Here are a few changes to bring to your scenarios file.
|
|
||
| Scénario: au bookshelf | ||
|
|
||
| Soit "Les fables de La Fontaine" le document principal |
There was a problem hiding this comment.
The title will be converted into an HTTP-URI.
Therefore you have to choose a title that was already used.
You can look at those:
| Scénario: au bookshelf | ||
|
|
||
| Soit "Les fables de La Fontaine" le document principal | ||
|
|
|
|
||
| Quand j'essaie de revenir au bookshelf | ||
| Alors je suis sur la page bookshelf | ||
| Et le titre de l'onglet est Hyperglosae |
There was a problem hiding this comment.
You could put brackets around "Hyperglosae".
By doing this you could reuse the step before the When to test that the page title is the same as the one you opened.
| Soit "Les fables de La Fontaine" le document principal | ||
|
|
||
| Quand j'essaie de revenir au bookshelf | ||
| Alors je suis sur la page bookshelf |
There was a problem hiding this comment.
The translation for "bookshelf" in French is "étagère".
|
|
||
| Soit "Les fables de La Fontaine" le document principal | ||
|
|
||
| Quand j'essaie de revenir au bookshelf |
There was a problem hiding this comment.
The translation for "bookshelf" in French is "étagère".
Forgot to change one instance of bookshelf to "étagère", and a typo.
|
@AdePeti @gd-utt @Lysakolie Thank you for your contribution. Don't forget that you should have exactly |
|
@AdePeti @gd-utt @Lysakolie Thank you for your contribution. Please don't forget that your pull request won't be integrated if your commits they don't follow strict naming conventions. It is quite easy with Git-Fork. See how it was done for a different issue: #390 (comment) |
3 participants
We, Gabriel DOSNE gabriel.dosne@utt.fr and Morgane VIALA morgane.viala@utt.fr and Arthur DE PÉTIGNY SAINT ROMAIN arthur.de_petigny_saint_romain@utt.fr, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.