Skip to content

Hotfix server vulnerability, it leads to crash RakLib - #965

Open
genisyspromcpe wants to merge 1 commit into
Hydreon:masterfrom
genisyspromcpe:master
Open

Hotfix server vulnerability, it leads to crash RakLib#965
genisyspromcpe wants to merge 1 commit into
Hydreon:masterfrom
genisyspromcpe:master

Conversation

@genisyspromcpe

@genisyspromcpe genisyspromcpe commented May 19, 2020

Copy link
Copy Markdown

This foolishness (check) was made by the developer of SteadFast2, attacking without creating a session, we just get a crash RakLib and an error about an exception not captured.
GDrs7_m9ytg

@IceCruelStuff

Copy link
Copy Markdown

#926 (comment)

@ZloyNick

Copy link
Copy Markdown

#926 (comment)

vchibikov merges some times.

@dktapps

dktapps commented May 20, 2020

Copy link
Copy Markdown
Member

He merges his own PRs all the time, yes. Here's a list of every PR that's ever been merged that wasn't made by vchibikov. Notice that they are all dated 2017 or earlier. https://github.com/Hydreon/Steadfast2/pulls?q=is%3Apr+is%3Amerged+not-author%3Avchibikov

@TheShermanTanker

Copy link
Copy Markdown

He merges his own PRs all the time, yes. Here's a list of every PR that's ever been merged that wasn't made by vchibikov. Notice that they are all dated 2017 or earlier. https://github.com/Hydreon/Steadfast2/pulls?q=is%3Apr+is%3Amerged+not-author%3Avchibikov

Now that the Lifeboat Server has since retired Steadfast 2 for their own proprietary fork of Pocketmine this statement is sadly 100% true (There was still a 0.000000001% of an accepted PR, now it's definitively 0%)

@dktapps

dktapps commented Jan 2, 2021

Copy link
Copy Markdown
Member

@TheShermanTanker please quit necroposting, you don't have any idea what you're talking about and this is just polluting people's notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants