Skip to content

Added setPressAndHoldEnabled to allow users to toggle that behaviour on the Mac#304

Open
Folcon wants to merge 2 commits into
HumbleUI:mainfrom
Folcon:main
Open

Added setPressAndHoldEnabled to allow users to toggle that behaviour on the Mac#304
Folcon wants to merge 2 commits into
HumbleUI:mainfrom
Folcon:main

Conversation

@Folcon
Copy link
Copy Markdown

@Folcon Folcon commented Mar 20, 2026

Just putting this up here and referencing #303

I need to update HumbleUI to make it work with the current JWM to test it properly

@Folcon Folcon changed the title Added setPressAndHoldEnabled to allow users to toggle that behaviour on the Mac #303 Added setPressAndHoldEnabled to allow users to toggle that behaviour on the Mac Mar 20, 2026
@Folcon
Copy link
Copy Markdown
Author

Folcon commented Mar 20, 2026

Ok, I've updated HumbleUI/HumbleUI#94 as well, this should bring HumbleUI in line with where JWM is and up to date with skija version 0.143.5

Let me know if you're happy with it or want some changes done to either of these repos =)

PS: Can I also say well done! This is getting awesome! =)

…ly deliver input

This allows supporting the macos accent popup and keyrepeat
@tonsky
Copy link
Copy Markdown
Collaborator

tonsky commented May 18, 2026

I am going through pending issues updating status, this one still needs some work outlined in #303 (comment). Feel free to jump on it or I’ll get to it myself eventually


  • You want no pressAndHold when outside but you also want default behavior when inside. And default can be either with pressAndHold or without. So it’s not just enable/disable, we also need a way to determine system value.
  • I added isPressAndHoldEnabled to match setPressAndHoldEnabled
  • I think we need something like isPressAndHoldEnabledGlobally which will just check the value of OS setting. Then we can use this + set to match system behavior in text fields, not just “enable always”
  • In your implementation, backspace stops working. It now produces unreadable character that it deletes instead of deleting a last character before it. You can check it in demo that I added (toggle PressAndHold with Cmd+A). We definitely need this resolved
  • It looks like I borrowed implementation from JetBrains, can you look what they are doing and do the same maybe? https://github.com/JetBrains/JetBrainsRuntime/blob/725d9778dd299206127c8538c3174f18b9111fe0/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m#L373

There is also a patch for demo #303 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants