Skip to content

Updated HtmlUnit to pick up the fixes for Neko #148 - #1017

Closed
rschwietzke wants to merge 1 commit into
HtmlUnit:masterfrom
rschwietzke:neko-148-dombuilder-thread-fix
Closed

Updated HtmlUnit to pick up the fixes for Neko #148#1017
rschwietzke wants to merge 1 commit into
HtmlUnit:masterfrom
rschwietzke:neko-148-dombuilder-thread-fix

Conversation

@rschwietzke

Copy link
Copy Markdown
Contributor

Required changes to fix the shared-by-accident problem within Neko HTMLELements and the use in HtmlUnitNekoDOMBuilder

@rbri

rbri commented Sep 29, 2025

Copy link
Copy Markdown
Member

@rschwietzke hope the current impl is now correct and the performance is comparable to the last version.

Have tried again to get an idea about the performance comparison between the last release and the current code

https://raw.githubusercontent.com/HtmlUnit/htmlunit-jmh-benchmarks/refs/heads/main/src/main/java/org/htmlunit/jmh/benchmarks/htmlunit/HtmlParserBenchmark.md

have added another real huge html file - html-standard.html

Looks like the performance with and without cache is similar, i think we should stay with the cache and hope for further good ideas to improve the whole thing.

@rbri rbri closed this Sep 29, 2025
@rschwietzke

Copy link
Copy Markdown
Contributor Author

I will revist the benchmark later this week and use my machine for comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants