Updated HtmlUnit to pick up the fixes for Neko #148 - #1017
Closed
rschwietzke wants to merge 1 commit into
Closed
Conversation
Member
|
@rschwietzke hope the current impl is now correct and the performance is comparable to the last version. Have tried again to get an idea about the performance comparison between the last release and the current code have added another real huge html file - html-standard.html Looks like the performance with and without cache is similar, i think we should stay with the cache and hope for further good ideas to improve the whole thing. |
Contributor
Author
|
I will revist the benchmark later this week and use my machine for comparison. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required changes to fix the shared-by-accident problem within Neko
HTMLELementsand the use inHtmlUnitNekoDOMBuilder