Skip to content

opencv: remove openvino dependency#232996

Merged
BrewTestBot merged 2 commits into
mainfrom
opencv-openvino-macos
Aug 10, 2025
Merged

opencv: remove openvino dependency#232996
BrewTestBot merged 2 commits into
mainfrom
opencv-openvino-macos

Conversation

@carlocab
Copy link
Copy Markdown
Member

@carlocab carlocab commented Aug 10, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

openvino is currently broken on Linux and it seems to constantly break
during updates, so let's leave it out for now.

Omitting the revision bump since this is getting one in #227169.

@carlocab carlocab added CI-no-bottles Merge without publishing bottles CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Aug 10, 2025
@github-actions github-actions Bot added python Python use is a significant feature of the PR or issue ffmpeg FFMPEG use is a significant feature of the PR or issue labels Aug 10, 2025
@carlocab carlocab force-pushed the opencv-openvino-macos branch 2 times, most recently from 24f1091 to 90e5c7e Compare August 10, 2025 11:24
@carlocab carlocab removed the CI-no-bottles Merge without publishing bottles label Aug 10, 2025
@carlocab carlocab force-pushed the opencv-openvino-macos branch from 90e5c7e to f400353 Compare August 10, 2025 11:33
@carlocab carlocab changed the title opencv: use openvino only on macOS opencv: remove openvino dependency Aug 10, 2025
@carlocab carlocab force-pushed the opencv-openvino-macos branch from f400353 to 2aacfb0 Compare August 10, 2025 11:34
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Aug 10, 2025
`openvino` is currently broken on Linux and it seems to constantly break
during updates, so let's leave it out for now.
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 10, 2025
@carlocab carlocab force-pushed the opencv-openvino-macos branch from 2aacfb0 to d34d97b Compare August 10, 2025 13:23
@cho-m
Copy link
Copy Markdown
Member

cho-m commented Aug 10, 2025

Noting that Linux may still fail as OpenCV was one of the patchelf impacted formulae.

Though maybe if the resulting ELF header changes then issue could randomly stop occurring as not all Protobuf formulae are impacted (or maybe we just aren't testing them sufficiently and are shipping broken binaries).

Perhaps worth checking how upstream patchelf behaves in case pulling in new changes will help (which I think we need for arm64 Linux Go issues): Bo98/patchelf.rb@e26a04d

@carlocab
Copy link
Copy Markdown
Member Author

Yea, I've pinged @Bo98 for help here to try to get this fixed properly. Until then, hopefully opencv isn't impacted when not linked with openvino.

@carlocab
Copy link
Copy Markdown
Member Author

dvr-scan should hopefully be fixed by rebuild in #231535.

@github-actions
Copy link
Copy Markdown
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 10, 2025
@BrewTestBot BrewTestBot enabled auto-merge August 10, 2025 18:17
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 10, 2025
Merged via the queue into main with commit 4b3c394 Aug 10, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the opencv-openvino-macos branch August 10, 2025 18:26
@carlocab
Copy link
Copy Markdown
Member Author

Maybe this will work? Homebrew/brew#20403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ffmpeg FFMPEG use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants