Skip to content

python@3.{10,11}: revision bump for alias migration#123165

Closed
branchv wants to merge 2 commits into
Homebrew:masterfrom
branchv:python3
Closed

python@3.{10,11}: revision bump for alias migration#123165
branchv wants to merge 2 commits into
Homebrew:masterfrom
branchv:python3

Conversation

@branchv
Copy link
Copy Markdown
Member

@branchv branchv commented Feb 14, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We didn't rev bump in #114154 but I think we should so all users have the same python3

@branchv branchv added long build Set a long timeout for formula testing CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Feb 14, 2023
@michaelblyons
Copy link
Copy Markdown

Does the rev-bump need to go through "The tests are failing," "That one pre-dates the change," and so on? It took four months to get the #114154 through. Please don't delay too long before users actually see the benefits.

@branchv
Copy link
Copy Markdown
Member Author

branchv commented Feb 16, 2023

No this should be good to merge after a single CI run, we didn't intend for the other PR to take that long

@branchv branchv added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 16, 2023
@p-linnane p-linnane removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 16, 2023
@branchv
Copy link
Copy Markdown
Member Author

branchv commented Feb 17, 2023

Forgot the self-hosted label so Linux got halfway through before timing out, but without any failures. Don't think it's worth rerunning

@branchv branchv added the ready to merge PR can be merged once CI is green label Feb 17, 2023
@SMillerDev
Copy link
Copy Markdown
Member

Do we have bottles for everything?

@branchv
Copy link
Copy Markdown
Member Author

branchv commented Feb 17, 2023

Yes all bottles were built/uploaded (here's the linux one)

@BrewTestBot
Copy link
Copy Markdown
Contributor

:shipit: @chenrui333 has triggered a merge.

@chenrui333
Copy link
Copy Markdown
Member

Yeah, I can see the bottles for the linux run as well

2 bottles
ls: cannot access 'failed/*.json': No such file or directory
0 failed bottles

@branchv branchv deleted the python3 branch February 18, 2023 11:24
@github-actions github-actions Bot added the outdated PR was locked due to age label Mar 20, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants