Skip to content

mapnik: migrate to [email protected]#119500

Closed
ryenus wants to merge 1 commit into
Homebrew:masterfrom
ryenus:mapnik-py311
Closed

mapnik: migrate to [email protected]#119500
ryenus wants to merge 1 commit into
Homebrew:masterfrom
ryenus:mapnik-py311

Conversation

@ryenus
Copy link
Copy Markdown
Contributor

@ryenus ryenus commented Jan 1, 2023

Following up #114154

Update mapnik to use [email protected] instead of [email protected],

@BrewTestBot BrewTestBot added boost Boost use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Jan 1, 2023
@cho-m
Copy link
Copy Markdown
Member

cho-m commented Jan 1, 2023

This won't work. Bundled scons is too old. Again, anything with more than 1 version difference usually will require additional fixes.

I was actually working on this right now. May create a PR to supersede.

@cho-m cho-m closed this Jan 1, 2023
@cho-m
Copy link
Copy Markdown
Member

cho-m commented Jan 1, 2023

See #119502 for replacing scons.

@cho-m cho-m added the superseded PR was replaced by another PR label Jan 1, 2023
@ryenus
Copy link
Copy Markdown
Contributor Author

ryenus commented Jan 1, 2023

Ahh, got it! I was thinking maybe there were a few misses, apparently that's not the case, thank you!

@cho-m
Copy link
Copy Markdown
Member

cho-m commented Jan 1, 2023

We've usually tested all formulae by the time Python migration is done. Only ones that may be worth checking are formulae with recent releases.

I've been going through some formulae with old Python versions to see what fixes can be added now.

The remaining ones are going to be

  • spidermonkey which uses an old bundled copy of virtualenv. May be updated in new release; however, we have issues building the new release.
  • protobuf@3 which doesn't have fixes needed to build bindings for Python 3.11.

@github-actions github-actions Bot added the outdated PR was locked due to age label Feb 1, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 1, 2023
@ryenus ryenus deleted the mapnik-py311 branch February 21, 2023 03:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

boost Boost use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue outdated PR was locked due to age superseded PR was replaced by another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants