Skip to content

root: migrate to python@3.10 #107745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carlocab wants to merge 1 commit into from
Closed

root: migrate to python@3.10 #107745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions Formula/root.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ class Root < Formula
url "https://root.cern.ch/download/root_v6.26.06.source.tar.gz"
sha256 "b1f73c976a580a5c56c8c8a0152582a1dfc560b4dd80e1b7545237b65e6c89cb"
license "LGPL-2.1-or-later"
revision 1
head "https://github.com/root-project/root.git", branch: "master"

livecheck do
Expand Down Expand Up @@ -40,7 +41,7 @@ class Root < Formula
depends_on "openblas"
depends_on "openssl@1.1"
depends_on "pcre"
depends_on "python@3.9"
depends_on "python@3.10"
depends_on "sqlite"
depends_on "tbb"
depends_on :xcode
Expand All @@ -62,6 +63,8 @@ class Root < Formula
fails_with gcc: "5"

def install
python = Formula["python@3.10"].opt_bin/"python3.10"

ENV.append "LDFLAGS", "-Wl,-rpath,#{lib}/root"

inreplace "cmake/modules/SearchInstalledSoftware.cmake" do |s|
Expand All @@ -75,7 +78,7 @@ def install
args = std_cmake_args + %W[
-DCLING_CXX_PATH=clang++
-DCMAKE_INSTALL_ELISPDIR=#{elisp}
-DPYTHON_EXECUTABLE=#{Formula["python@3.9"].opt_bin}/python3
-DPYTHON_EXECUTABLE=#{python}
-DCMAKE_CXX_STANDARD=17
-Dbuiltin_cfitsio=OFF
-Dbuiltin_freetype=OFF
Expand All @@ -99,23 +102,19 @@ def install
-GNinja
]

# Homebrew now sets CMAKE_INSTALL_LIBDIR to /lib, which is incorrect
# for ROOT with gnuinstall, so we set it back here.
args << "-DCMAKE_INSTALL_LIBDIR=lib/root"

# Workaround the shim directory being embedded into the output
inreplace "build/unix/compiledata.sh", "`type -path $CXX`", ENV.cxx

mkdir "builddir" do
system "cmake", "..", *args
system "ninja", "install"
# Homebrew now sets CMAKE_INSTALL_LIBDIR to /lib, which is incorrect
# for ROOT with gnuinstall, so we set it back here.
system "cmake", "-S", ".", "-B", "builddir", *args, *std_cmake_args(install_libdir: "lib/root")
system "cmake", "--build", "builddir"
system "cmake", "--install", "builddir"

chmod 0755, Dir[bin/"*.*sh"]
chmod 0755, bin.glob("*.*sh")

version = Language::Python.major_minor_version Formula["python@3.9"].opt_bin/"python3"
pth_contents = "import site; site.addsitedir('#{lib}/root')\n"
(prefix/"lib/python#{version}/site-packages/homebrew-root.pth").write pth_contents
end
pth_contents = "import site; site.addsitedir('#{lib}/root')\n"
(prefix/Language::Python.site_packages(python)/"homebrew-root.pth").write pth_contents
end

def caveats
Expand Down Expand Up @@ -164,6 +163,6 @@ def caveats
assert_equal "Hello, world!\n", shell_output("./a.out")

# Test Python module
system Formula["python@3.9"].opt_bin/"python3", "-c", "import ROOT; ROOT.gSystem.LoadAllLibraries()"
system Formula["python@3.10"].opt_bin/"python3.10", "-c", "import ROOT; ROOT.gSystem.LoadAllLibraries()"
end
end