Conversation
8098cf2 to
f62a1f8
Compare
| next if match.nil? | ||
|
|
||
| "#{match[1]},#{match[2]}" | ||
| end |
There was a problem hiding this comment.
@samford Is page_match the only real option here? AFAIK there isn't a strategy to match releases on anything except for GitHub?
We could PageMatch the releases page instead if that is better than hitting Codeberg - https://openrgb.org/releases.html
There was a problem hiding this comment.
We can technically check the Codeberg API (e.g., https://codeberg.org/api/v1/repos/OpenRGB/OpenRGB/releases/latest) and we do that in the librewolf cask. It's possible to create similar strategies for Codeberg but I generally wait to create new strategies until there's enough usage in livecheck blocks to justify it (currently librewolf has the only livecheck block doing this).
I'm also trying to put it off until I've added support for strategy options, as it would be nice to combine GithubLatest and GithubReleases into one Github strategy where we instead pass an option to control the behavior (maybe something like strategy :github, type: :latest but I haven't decided how to approach it yet). If we go down that path, it would allow us to avoid having to add two strategies for Codeberg as well.
That said, it may be better to continue checking the openrgb.org releases page, as there are separate releases for 1.0rc2 on Codeberg (the main release and then a WinRing0 variant) and those are simply combined into one release on the first-party website. The WinRing0 release was correctly created before the main 1.0rc2 release and only preceded it by two minutes, so we may not have to worry about the "latest" release being a variant but probably better safe than sorry.
With that in mind, we can restore the existing livecheck block and temporarily loosen the regex to allow matching RC versions until the next stable release (with a comment to remind us to return to only matching stable releases when we update to the next stable version). One moment and I'll create suggestions.
There was a problem hiding this comment.
The existing livecheck block will work if we temporarily modify it to allow matching RC versions. We should restore the original regex when we update to the next stable version (so we only match stable versions going forward) but this will work for now.
75edcb5 to
4f82eaa
Compare
4f82eaa to
d692bcf
Compare
The previous version (0.9) is broken on Apple Silicon chips, causing crashes or failing to initialize when clicking the "Rescan devices" button. This update restores functionality for macOS ARM64 users.
The binaries have been moved to codeberg, so the download URL has also been updated.
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.zapstanza paths.