Conversation
Casks/i/idevice-pair.rb
Outdated
| @@ -0,0 +1,18 @@ | |||
| cask "idevice-pair" do | |||
| version "0.1.9" | |||
There was a problem hiding this comment.
This version doesn't currently match the latest tag, so the previous version is what is actually being downloaded and installed at the moment.
https://github.com/jkcoxson/idevice_pair/releases/tag/v0.1.9-rppairing
The livecheck block may need a regex to capture extra variable parts in the version as required.
We can also likely check tags with the :git strategy instead of having to use :github_latest which is heavier.
There was a problem hiding this comment.
Would this work?
regex(/^v?(\d+(?:\.\d+)*(?:-\w+)?)$/i)
See https://github.com/jkcoxson/idevice_pair/tags, especially https://github.com/jkcoxson/idevice_pair/releases/tag/v0.1.3p1
There was a problem hiding this comment.
Technically we could set the version to 0.1.9-rppairing and use #{version.split("-").first} in the cask url but if upstream were to create a subsequent release using the same version with a suffix that starts with a letter before "r", livecheck would erroneously treat it as lower than the cask version (due to how string comparison works).
For what it's worth, if you delete this livecheck block, livecheck will use the Git strategy with the cask url by default and the default strategy regex simply removes non-digit text at the start of tags ("v" here) and captures the rest, so it would give 0.1.9-rppairing as newest. We only add a livecheck block when it's necessary and right now that doesn't seem to be the case, so we can omit it here.
That said, suffice to say this isn't a reasonable way to approach versioning and the real solution is for someone to create an upstream issue to ask them to use a new version (e.g., 0.1.10) when publishing changes instead of recycling existing versions by adding a suffix like -rppairing. One-off versions like 0.1.3p1 (which only included fixes for regressions) are also an indicator that they may need to reconsider how they're thinking about versioning (i.e., I would have used 0.1.4).
If upstream increments the patch version when they feel the urge to add a suffix, that would prevent these problems in the future. If they also create a 0.1.10 release (even if it's the same as 0.1.9-rppairing), that would allow us to use a more reasonable approach here in the cask.
There was a problem hiding this comment.
Remove livecheck block. I will create an issue for the package about versioning later.
|
Please try to add a zap stanza. The linked documentation provides some recommended methods to create it. |
I didn't find anything after launching the app and changing its settings. It's actually a non-native macOS app, which is probably why no files remain on the system. |
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.zapstanza paths.AI generates the first version of formulae, then I manually verified that it works. App doesn't generate settings files, cache files, etc.