Skip to content

idevice-pair 0.1.9 (new cask)#257069

Open
rakleed wants to merge 3 commits intoHomebrew:mainfrom
rakleed:main
Open

idevice-pair 0.1.9 (new cask)#257069
rakleed wants to merge 3 commits intoHomebrew:mainfrom
rakleed:main

Conversation

@rakleed
Copy link
Copy Markdown
Contributor

@rakleed rakleed commented Apr 1, 2026


After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes, including zap stanza paths.

AI generates the first version of formulae, then I manually verified that it works. App doesn't generate settings files, cache files, etc.


@BrewTestBot BrewTestBot added new cask missing zap Cask is missing a zap stanza, please add one. labels Apr 1, 2026
@bevanjkay bevanjkay changed the title idevice-pair idevice-pair 0.1.9 (new cask) Apr 1, 2026
@@ -0,0 +1,18 @@
cask "idevice-pair" do
version "0.1.9"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version doesn't currently match the latest tag, so the previous version is what is actually being downloaded and installed at the moment.

https://github.com/jkcoxson/idevice_pair/releases/tag/v0.1.9-rppairing

The livecheck block may need a regex to capture extra variable parts in the version as required.
We can also likely check tags with the :git strategy instead of having to use :github_latest which is heavier.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work?

regex(/^v?(\d+(?:\.\d+)*(?:-\w+)?)$/i)

See https://github.com/jkcoxson/idevice_pair/tags, especially https://github.com/jkcoxson/idevice_pair/releases/tag/v0.1.3p1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to defer to @samford on this one.

Copy link
Copy Markdown
Member

@samford samford Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we could set the version to 0.1.9-rppairing and use #{version.split("-").first} in the cask url but if upstream were to create a subsequent release using the same version with a suffix that starts with a letter before "r", livecheck would erroneously treat it as lower than the cask version (due to how string comparison works).

For what it's worth, if you delete this livecheck block, livecheck will use the Git strategy with the cask url by default and the default strategy regex simply removes non-digit text at the start of tags ("v" here) and captures the rest, so it would give 0.1.9-rppairing as newest. We only add a livecheck block when it's necessary and right now that doesn't seem to be the case, so we can omit it here.

That said, suffice to say this isn't a reasonable way to approach versioning and the real solution is for someone to create an upstream issue to ask them to use a new version (e.g., 0.1.10) when publishing changes instead of recycling existing versions by adding a suffix like -rppairing. One-off versions like 0.1.3p1 (which only included fixes for regressions) are also an indicator that they may need to reconsider how they're thinking about versioning (i.e., I would have used 0.1.4).

If upstream increments the patch version when they feel the urge to add a suffix, that would prevent these problems in the future. If they also create a 0.1.10 release (even if it's the same as 0.1.9-rppairing), that would allow us to use a more reasonable approach here in the cask.

Copy link
Copy Markdown
Contributor Author

@rakleed rakleed Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove livecheck block. I will create an issue for the package about versioning later.

@bevanjkay
Copy link
Copy Markdown
Member

Please try to add a zap stanza. The linked documentation provides some recommended methods to create it.

@rakleed rakleed requested a review from bevanjkay April 1, 2026 11:56
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Apr 1, 2026
@rakleed
Copy link
Copy Markdown
Contributor Author

rakleed commented Apr 1, 2026

Please try to add a zap stanza. The linked documentation provides some recommended methods to create it.

I didn't find anything after launching the app and changing its settings. It's actually a non-native macOS app, which is probably why no files remain on the system.

@rakleed rakleed requested a review from samford April 2, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants