Conversation
Introduce a new unite-pro cask for the separate Unite Pro 1.x product line, preserving the existing unite cask on 6.x for compatibility and smoother upgrades. Made-with: Cursor
Align app artifact name with vendor zip contents and set minimum macOS to :sonoma to match the app bundle metadata. Made-with: Cursor
|
How does this differ from the existing https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/u/unite.rb |
Hey! Unite Pro is a paid major upgrade to Unite 6 (last non-pro version). The non pro version is no longer sold, therefore the page redirects to Unite Pro. However, the cask should be separate because Unite 6 users will not want their app updated automatically as their existing license would not work for Pro. |
|
Licensing isn't usually something we worry about on the Homebrew side. Many applications don't have licenses that apply across major version updates. If it is indeed the same product then we should update the casks to match. Is version 6 of unite still available via your website? If not, then the cask should be replaced with this version. |
Follow maintainer guidance to update the existing unite cask to the current upstream product line instead of introducing a separate unite-pro token. Made-with: Cursor
| @@ -1,22 +1,22 @@ | |||
| cask "unite" do | |||
There was a problem hiding this comment.
The token should indeed change to unite-pro. The remapping can be added to the https://github.com/Homebrew/homebrew-cask/blob/main/cask_renames.json file.
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.zapstanza paths.AI assisted with drafting and iterating on the cask.
Manual verification performed:
app "Unite Pro.app"based on archive contents.>= :sonomato match app bundle metadata.zappaths against existingunitecask conventions.brew style --fix,brew audit --cask --new --online, and install/uninstall locally (install tested using a temporary appdir to avoid replacing an existing local app).