Skip to content

Fix overflow in count_uses #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marvinborner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix overflow in count_uses #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/hvm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1955,8 +1955,9 @@ fn PBind* parse_bind_lookup(u32 name, int side, int *skipped) {
// Count the number of uses of a target variable in a term
// Variables are identified by tag + level (and ext for BJ mode).
fn u32 count_uses(Term t, u32 lvl, u8 tgt, u32 ext) {
Term *ts = (Term*)malloc(sizeof(Term) * 1024); // not recursive, since this is a desugared term
int ts_idx = 0;
u32 ts_cap = 1024;
Term *ts = (Term*)malloc(sizeof(Term) * ts_cap);
u32 ts_idx = 0;
ts[ts_idx++] = t;

u32 uses = 0;
Expand All @@ -1970,6 +1971,10 @@ fn u32 count_uses(Term t, u32 lvl, u8 tgt, u32 ext) {
u32 ari = term_arity(t);
for (u32 i = 0; i < ari; i++) {
u64 loc = vl + i;
if (ts_idx == ts_cap) {
ts_cap *= 2;
ts = (Term*)realloc(ts, sizeof(Term) * ts_cap);
}
ts[ts_idx++] = HEAP[loc];
}
}
Expand Down