Skip to content

Notebook: fix "TabsContent must be used within Tabs" on multi-statement SQL cells #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Panthevm merged 1 commit into from
Jul 7, 2026
Merged

Notebook: fix "TabsContent must be used within Tabs" on multi-statement SQL cells #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions src/routes/notebooks.$id.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,10 @@ export function SqlCellView({
onResultChange?.(null);
};

const [activeTab, setActiveTab] = useState(0);
const hasResponse = results !== null || error !== null;
const multiple = !!results && results.length > 1;
const safeActive = results ? Math.min(activeTab, results.length - 1) : 0;

return (
<div className="group/cell -mx-3 mt-4 mb-4 rounded-lg border border-border-default bg-bg-primary overflow-hidden">
Expand Down Expand Up @@ -671,14 +674,28 @@ export function SqlCellView({
/>
</div>
{hasResponse && (
<>
<HSComp.Tabs
value={String(safeActive)}
onValueChange={(v) => setActiveTab(Number(v))}
className="flex flex-col min-h-0"
>
<div className="flex items-center justify-between bg-bg-secondary pl-3 pr-4 h-10 border-t border-b border-border-default">
<span className="text-sm font-medium text-text-secondary shrink-0">
Result
{results
? ` (${results.reduce((s, r) => s + (r.result?.length ?? 0), 0)})`
: ""}
</span>
{multiple ? (
<HSComp.TabsList>
{results?.map((r, i) => (
<HSComp.TabsTrigger key={`${r.query}-${i}`} value={String(i)}>
Query-{i + 1} ({r.result?.length ?? 0})
</HSComp.TabsTrigger>
))}
</HSComp.TabsList>
) : (
<span className="text-sm font-medium text-text-secondary shrink-0">
Result
{results
? ` (${results.reduce((s, r) => s + (r.result?.length ?? 0), 0)})`
: ""}
</span>
)}
<div className="flex items-center gap-3">
{duration !== undefined && (
<span className="flex items-center text-text-secondary text-sm">
Expand All @@ -698,7 +715,7 @@ export function SqlCellView({
onCancel={() => undefined}
/>
</div>
</>
</HSComp.Tabs>
)}
</div>
);
Expand Down