Skip to content

Pipelinewise number handling #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eculicny merged 3 commits into from
Nov 16, 2020
Merged

Pipelinewise number handling #1

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f978909
Updated schema generation to handle number format and be pipelinewise…
eculicny Nov 16, 2020
6a7b719
Reverted anyOf to array change as its unnecessary
eculicny Nov 16, 2020
deb592f
Revert "Reverted anyOf to array change as its unnecessary" This rever…
eculicny Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tap_google_sheets/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,13 @@ def get_sheet_schema_columns(sheet):
elif column_number_format_type == 'TEXT':
col_properties = {'type': ['null', 'string']}
column_gs_type = 'stringValue'
elif column_number_format_type == 'NUMBER':
col_properties = {'type': ['null', 'number']}
column_gs_type = 'numberType'
else:
# Interesting - order in the anyOf makes a difference.
# Number w/ multipleOf must be listed last, otherwise errors occur.
col_properties = {
col_properties = {
'anyOf': [
{
'type': 'null'
Expand Down