[cppia] Respect jit exceptions in interp mode#1188
Merged
Simn merged 3 commits intoApr 7, 2025
Conversation
When running in interp mode, native c++ exception handling is used, but when running jit mode, jumps are used along with ctx->exception. This means that an exception thrown from jit mode is not respected in interp mode. This can cause problems with local functions (which are interpreted even in jit mode). When a local function calls a compiled function that throws an exception, the exception is ignored until we return back into a compiled function. This patch fixes the problem by checking ctx->exception when running in interp mode, to make sure that no exception has been thrown from a jit compiled function.
tobil4sk
force-pushed
the
fix/cppia-jit-local-func-exceptions
branch
from
ebfb2c3 to
18af688
Compare
Member
|
@hughsando Could you check if this makes sense? |
Member
|
Yes, I think it makes sense. |
Member
|
Thanks for checking! I'll merge this as-is in order to allow HaxeFoundation/haxe#11922. We can perhaps improve on it later. |
This was referenced Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in interp mode, native c++ exception handling is used, but when running jit mode, jumps are used along with ctx->exception.
This means that an exception thrown from jit mode is not respected in interp mode. This can cause problems with local functions (which are interpreted even in jit mode). When a local function calls a compiled function that throws an exception, the exception is ignored until we return back into a compiled function.
This patch fixes the problem by checking ctx->exception when running in interp mode, to make sure that no exception has been thrown from a jit compiled function.
This fixes #876.