fix: load CLI version in ESM#47
Open
iccccccccccccc wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24
Changes
requirefunction withcreateRequire(import.meta.url)for the ESM CLIpackage.jsonthrough that ESM-compatible require instead of relying on a missing globalrequire0.0.0fallback if the package metadata cannot be readVerification
npm run buildnode dist/cli.js --version->1.0.1node dist/cli.js --helpshows@hailbytes/security-headers v1.0.1npm run typecheckI also ran
npm test; it currently gets through 55/59 tests, with four existing Permissions-Policy / grade-boundary assertions failing outside this CLI version path.